You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/07/07 19:44:59 UTC

[GitHub] [spark] cloud-fan opened a new pull request, #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

cloud-fan opened a new pull request, #41893:
URL: https://github.com/apache/spark/pull/41893

   …active conf
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   It's counterintuitive that the SQL parser does not respect the conf of the SparkSession which holds it, but use the active SQLConf instead. This PR makes the session pass the SQLConf to the parser when creating it.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   avoid potential bugs like https://github.com/apache/spark/pull/41759
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   No
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   existing tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1257653324


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystSqlParser.scala:
##########
@@ -16,11 +16,13 @@
  */
 package org.apache.spark.sql.catalyst.parser
 
+import org.apache.spark.sql.internal.SQLConf
+
 /**
  * Concrete SQL parser for Catalyst-only SQL statements.
  */
 class CatalystSqlParser extends AbstractSqlParser {

Review Comment:
   It's also used for interval literal parsing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf
URL: https://github.com/apache/spark/pull/41893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] hvanhovell commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1257245311


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystSqlParser.scala:
##########
@@ -16,11 +16,13 @@
  */
 package org.apache.spark.sql.catalyst.parser
 
+import org.apache.spark.sql.internal.SQLConf
+
 /**
  * Concrete SQL parser for Catalyst-only SQL statements.
  */
 class CatalystSqlParser extends AbstractSqlParser {

Review Comment:
   It needs SQLConf for ANSI mode. It does make a difference for what we allow in terms of keywords. It is not super problematic because you can typically fix this by quoting identifiers, the only problem is that within the same session you could have different parsing behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41893:
URL: https://github.com/apache/spark/pull/41893#issuecomment-1633985749

   It seems useful to have a singleton parser instance, which can still change its behavior w.r.t. the active SQLConf.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41893:
URL: https://github.com/apache/spark/pull/41893#issuecomment-1625986845

   cc @yaooqinn @amaliujia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zml1206 commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1259095033


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   `spark.sql("select '2023-01-01' as dt").select(expr("dt + INTERVAL 1 YEAR as dt1"))`, `expr`  use the active SQLConf, should it be fix or is still the original design? @cloud-fan @yaooqinn 
     



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1259087547


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   Sure @cloud-fan 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zml1206 commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1261894569


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   
   I understand, thanks for clarifying.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1259058533


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   That's a good point. It's not only about the parser, but also expression instantiations.
   
   @yaooqinn can you fix other DF APIs to wrap with `sparkSession.withActive`? I believe there are more APIs that take a SQL string and parse it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zml1206 commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1259095033


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   `spark.sql("select '2023-01-01' as dt").select(expr("dt + INTERVAL 1 YEAR as dt1"))`, `expr`  use the active SQLConf, should it be modified?
     



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the active conf

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1260973475


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   `expr` is a static function. It can only use the active sql conf.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1256375805


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystSqlParser.scala:
##########
@@ -16,11 +16,13 @@
  */
 package org.apache.spark.sql.catalyst.parser
 
+import org.apache.spark.sql.internal.SQLConf
+
 /**
  * Concrete SQL parser for Catalyst-only SQL statements.
  */
 class CatalystSqlParser extends AbstractSqlParser {

Review Comment:
   I checked all the caller side, it's not test only, but is only used from simple tasks like parsing table schema or table identifier, which doesn't need SQLConf at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] hvanhovell commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1257243793


##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -1570,7 +1570,7 @@ class Dataset[T] private[sql](
    * @since 2.0.0
    */
   @scala.annotation.varargs
-  def selectExpr(exprs: String*): DataFrame = sparkSession.withActive {

Review Comment:
   TBH I am not sure what is worse. The problem I foresee here is that expressions use SQLConf.get to get a configuration, and now we don't know what setting they will pick-up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org