[jira] Commented: (CASSANDRA-126) Incorrect IOException in SequenceFile when BF returns false positive

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704796#action_12704796 ] 

Jonathan Ellis commented on CASSANDRA-126:
------------------------------------------

If I understand what you are doing, shouldn't you take out the IOException catches that deal with the current way of doing things? e.g. in SSTable,

            catch( IOException ex )
            {
                logger_.info("Bloom filter false positive", ex);
            }

I'd also like to see a test case that exercises this code path.

> Incorrect IOException in SequenceFile when BF returns false positive
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-126
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-126
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>         Attachments: issue126.patch_v1
>
>
> In SequenceFile.AbstractReader.seekTo(), an IOException is thrown when a key can't be found in an SSTable. This is incorrect. The BF associated with the SSTable could return a false positive. So a key may indeed not be present in the SSTable file. We need to handle this case accordingly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.