[jira] [Commented] (OAK-4681) Automatically convert *all* "or" queries to "union" for SQL-2

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624917#comment-15624917 ] 

Thomas Mueller commented on OAK-4681:
-------------------------------------

http://svn.apache.org/r1767458 (trunk)

[~edivad], could you review this change? Because the original implementation is from you.

> Automatically convert *all* "or" queries to "union" for SQL-2
> -------------------------------------------------------------
>
>                 Key: OAK-4681
>                 URL: https://issues.apache.org/jira/browse/OAK-4681
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: query
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 1.5.13
>
>
> Currently, in OAK-1617, simple SQL-2 queries that contain "or" are converted to "union" if the cost is lower. However, more complex queries are not converted, see AndImpl.java, convertToUnion(), "in this case prefer to be conservative and don't optimize. This could happen when for example: WHERE (a OR b) AND (c OR d)." 
> It is implemented for XPath, and works fine there, so I think it is reasonable to do that for SQL-2 as well for trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)