You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Johny Rufus John <jr...@cloudera.com> on 2015/10/06 03:30:36 UTC
Review Request 39035: FLUME-2712: Optional channel errors slows down
the Source to Main channel event rate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39035/
-----------------------------------------------------------
Review request for Flume.
Bugs: FLUME-2712
https://issues.apache.org/jira/browse/FLUME-2712
Repository: flume-git
Description
-------
Optional channel errors slows down the Source to Main channel event rate. This change makes delivery to optional channel asynchronously.
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 1cce137
Diff: https://reviews.apache.org/r/39035/diff/
Testing
-------
Tested with optional channel setup to observe the performance improvement
Thanks,
Johny Rufus John
Re: Review Request 39035: FLUME-2712: Optional channel errors slows
down the Source to Main channel event rate
Posted by Johny Rufus John <jr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39035/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 8:13 p.m.)
Review request for Flume.
Bugs: FLUME-2712
https://issues.apache.org/jira/browse/FLUME-2712
Repository: flume-git
Description
-------
Optional channel errors slows down the Source to Main channel event rate. This change makes delivery to optional channel asynchronously.
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 1cce137
flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java 0656596
Diff: https://reviews.apache.org/r/39035/diff/
Testing
-------
Tested with optional channel setup to observe the performance improvement
Thanks,
Johny Rufus John
Re: Review Request 39035: FLUME-2712: Optional channel errors slows
down the Source to Main channel event rate
Posted by Johny Rufus John <jr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39035/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 12:10 a.m.)
Review request for Flume.
Bugs: FLUME-2712
https://issues.apache.org/jira/browse/FLUME-2712
Repository: flume-git
Description
-------
Optional channel errors slows down the Source to Main channel event rate. This change makes delivery to optional channel asynchronously.
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 1cce137
flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java 0656596
Diff: https://reviews.apache.org/r/39035/diff/
Testing
-------
Tested with optional channel setup to observe the performance improvement
Thanks,
Johny Rufus John
Re: Review Request 39035: FLUME-2712: Optional channel errors slows
down the Source to Main channel event rate
Posted by Johny Rufus John <jr...@cloudera.com>.
> On Oct. 6, 2015, 4:11 p.m., Jarek Cecho wrote:
> > flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java, line 86
> > <https://reviews.apache.org/r/39035/diff/1/?file=1091484#file1091484line86>
> >
> > Shouldn't we document the new configuration option?
Yes, we have to, since this option is going to be documented in every source, I thought we can do that as part of separate Jira
- Johny Rufus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39035/#review101651
-----------------------------------------------------------
On Oct. 6, 2015, 1:30 a.m., Johny Rufus John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39035/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:30 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2712
> https://issues.apache.org/jira/browse/FLUME-2712
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Optional channel errors slows down the Source to Main channel event rate. This change makes delivery to optional channel asynchronously.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 1cce137
>
> Diff: https://reviews.apache.org/r/39035/diff/
>
>
> Testing
> -------
>
> Tested with optional channel setup to observe the performance improvement
>
>
> Thanks,
>
> Johny Rufus John
>
>
Re: Review Request 39035: FLUME-2712: Optional channel errors slows
down the Source to Main channel event rate
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39035/#review101651
-----------------------------------------------------------
Looks reasonable to me, just one comment:
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java (line 86)
<https://reviews.apache.org/r/39035/#comment159101>
Shouldn't we document the new configuration option?
Jarcec
- Jarek Cecho
On Oct. 6, 2015, 1:30 a.m., Johny Rufus John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39035/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 1:30 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2712
> https://issues.apache.org/jira/browse/FLUME-2712
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Optional channel errors slows down the Source to Main channel event rate. This change makes delivery to optional channel asynchronously.
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 1cce137
>
> Diff: https://reviews.apache.org/r/39035/diff/
>
>
> Testing
> -------
>
> Tested with optional channel setup to observe the performance improvement
>
>
> Thanks,
>
> Johny Rufus John
>
>