[GitHub] [spark] zhenlineo commented on a diff in pull request #40675: [SPARK-42657][CONNECT] Support to find and transfer client-side REPL classfiles to server as artifacts

["zhenlineo (via GitHub)" <gi...@apache.org>]

zhenlineo commented on code in PR #40675:
URL: https://github.com/apache/spark/pull/40675#discussion_r1163214597


##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile:
##########
@@ -60,3 +60,4 @@ ENTRYPOINT [ "/opt/entrypoint.sh" ]
 
 # Specify the User that the actual main process will run as
 USER ${spark_uid}
+RUN export TERM=vt100 && script -qfc 'echo exit | amm -s' && rm typescript

Review Comment:
   Maybe this file instead? https://github.com/apache/spark/blob/master/dev/infra/Dockerfile
   
   I have a test build to save sometime for you -> https://github.com/apache/spark/pull/40745



##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/application/ReplE2ESuite.scala:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.application
+
+import java.io.{PipedInputStream, PipedOutputStream}
+import java.util.concurrent.{Executors, Semaphore, TimeUnit}
+
+import org.apache.commons.io.output.ByteArrayOutputStream
+
+import org.apache.spark.sql.connect.client.util.RemoteSparkSession
+
+class ReplE2ESuite extends RemoteSparkSession {

Review Comment:
   Can you add some doc about if there is anything extra to install to run this test? Two tests failed on my local machine with command:
   `sbt "testOnly org.apache.spark.sql.application.ReplE2ESuite"`
   
   Did I miss something?



##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/SimpleSparkConnectService.scala:
##########
@@ -38,7 +38,7 @@ private[sql] object SimpleSparkConnectService {
   private val stopCommand = "q"
 
   def main(args: Array[String]): Unit = {
-    val conf = new SparkConf()
+    val conf = new SparkConf().set("connect.test", "true")

Review Comment:
   Did you drop the line for `server.start` and `server.stop` in this file? 
   
   When you set the plugin, then a connect server will be started and stoped within the spark context. So there is no need to start an extra one in this tiny script.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org