You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2014/07/03 09:49:04 UTC

[GitHub] spark pull request: [SPARK-2082] stratified sampling in PairRDDFun...

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1025#discussion_r14500775
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala ---
    @@ -27,8 +27,12 @@ import scala.collection.Map
     import scala.collection.mutable
     import scala.collection.mutable.ArrayBuffer
     import scala.reflect.ClassTag
    +import scala.util.control.Breaks._
    --- End diff --
    
    This is not a native feature of Scala, neither a for loop. Try to use while with a flag that terminates the loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---