You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/02/26 10:23:08 UTC

[GitHub] spark pull request #19033: [SPARK-21811][SQL]Inconsistency when finding the ...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19033#discussion_r170547020
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
    @@ -150,9 +150,27 @@ object TypeCoercion {
       }
     
       private def findWiderCommonType(types: Seq[DataType]): Option[DataType] = {
    +    var awaitingString = false
    --- End diff --
    
    Maybe we should make a pass of all dataTypes here, and see whether there exists `StringType` and all other dataTypes can be promoted to `StringType`, under that case we can default return `StringType` instead of `None`, WDYT?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org