You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 18:03:21 UTC
Re: Review Request 70105: Increased timeout in
`generate-endpoint-help.py`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/
-----------------------------------------------------------
(Updated March 3, 2019, 7:03 p.m.)
Review request for mesos, Till Toenshoff and Vinod Kone.
Bugs: MESOS-9592
https://issues.apache.org/jira/browse/MESOS-9592
Repository: mesos
Description
-------
In CI starting master or agent process often took longer than the
allowed 10s which then lead to query timeouts and failed builds.
This patch increases the allowed time from 10s to 10min which should
allow the script to run to completion on even the most adverse machines.
Diffs
-----
support/generate-endpoint-help.py 91c13d797ea27737af42f5698d589b84664425c5
Diff: https://reviews.apache.org/r/70105/diff/1/
Testing (updated)
-------
`./support/generate-endpoint-help.py -c _/bin` generated endpoint help in `docs/endpoints`.
Thanks,
Benjamin Bannier
Re: Review Request 70105: Increased timeout in
`generate-endpoint-help.py`.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/#review213430
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2019, 6:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70105/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 6:03 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-9592
> https://issues.apache.org/jira/browse/MESOS-9592
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In CI starting master or agent process often took longer than the
> allowed 10s which then lead to query timeouts and failed builds.
>
> This patch increases the allowed time from 10s to 10min which should
> allow the script to run to completion on even the most adverse machines.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 91c13d797ea27737af42f5698d589b84664425c5
>
>
> Diff: https://reviews.apache.org/r/70105/diff/1/
>
>
> Testing
> -------
>
> `./support/generate-endpoint-help.py -c _/bin` generated endpoint help in `docs/endpoints`.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70105: Increased timeout in
`generate-endpoint-help.py`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70105/#review213379
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70105]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2019, 6:03 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70105/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 6:03 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-9592
> https://issues.apache.org/jira/browse/MESOS-9592
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In CI starting master or agent process often took longer than the
> allowed 10s which then lead to query timeouts and failed builds.
>
> This patch increases the allowed time from 10s to 10min which should
> allow the script to run to completion on even the most adverse machines.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 91c13d797ea27737af42f5698d589b84664425c5
>
>
> Diff: https://reviews.apache.org/r/70105/diff/1/
>
>
> Testing
> -------
>
> `./support/generate-endpoint-help.py -c _/bin` generated endpoint help in `docs/endpoints`.
>
>
> Thanks,
>
> Benjamin Bannier
>
>