You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Andrey (JIRA)" <ji...@apache.org> on 2017/07/21 09:37:00 UTC
[jira] [Comment Edited] (KAFKA-4915) Make logging consistent
[ https://issues.apache.org/jira/browse/KAFKA-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096059#comment-16096059 ]
Andrey edited comment on KAFKA-4915 at 7/21/17 9:36 AM:
--------------------------------------------------------
Not really. You log message with "WARN" log level. However the first word in message is "Error". If it is really error, then it should have log level "ERROR". If it's not an error, it should not have "Error" in the log message.
Sorry for such boring jira, but it makes sense to grep "Error" keyword and get only errors. + Setup monitoring so it can highlight errors with red and warnings in yellow.
And it's definitely not a major issue
was (Author: dernasherbrezon):
Not really. You log message with "WARN" log level. However the first word in message is "Error". If it is really error, then it should have log level "ERROR". If it's not an error, it should not have "Error" in the log message.
Sorry for such boring jira, but it makes sense to grep "Error" keyword and get only errors. + Setup monitoring so it can highlight errors with red and warnings in yellow.
> Make logging consistent
> -----------------------
>
> Key: KAFKA-4915
> URL: https://issues.apache.org/jira/browse/KAFKA-4915
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.10.1.1
> Reporter: Andrey
>
> Currently we see in logs:
> {code}
> WARN Error while fetching metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR} (org.apache.kafka.clients.NetworkClient:600)
> {code}
> Expected:
> {code}
> WARN unable to fetch metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR} (org.apache.kafka.clients.NetworkClient:600)
> {code}
> or
> {code}
> ERROR unable to fetch metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR} (org.apache.kafka.clients.NetworkClient:600)
> {code}
> See for reference: https://github.com/apache/kafka/blob/65650ba4dcba8a9729cb9cb6477a62a7b7c3714e/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L723
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)