[jira] Commented: (DERBY-2906) derbynet.jar & derbytools.jar incorrectly have a META-INF/services/java.sql.Driver entry

["Kristian Waagan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514979 ] 

Kristian Waagan commented on DERBY-2906:
----------------------------------------

I had a look at this issue.
There seems to be several ways to solve the problem and a few of them are:
 a) Delete the META-INF/services after the jar has been packaged (derby.jar and derbyclient.jar).
 b) Tighten the filters selecting which files to include from the META-INF directory.
 c) Order the jar build targets to avoid the problem

The problem arises because the build targets for the jars share the same "scratch space" and nothing is cleaned between the targets.
I will have a look and see which solution I opt for. Feedback up front is welcome.
Option c is too fragile and might cause problems if users build separate jars.
Option a is a two line fix (+comments).
I don't know enough to say if option b is sound, but it would probably be the safest one against future changes/additions.

I also discovered some jar build targets use an antcall, whereas others do the same "manually". I might also clean this up as part of this (separate diff, same issue).

> derbynet.jar & derbytools.jar incorrectly have a META-INF/services/java.sql.Driver entry
> ----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2906
>                 URL: https://issues.apache.org/jira/browse/DERBY-2906
>             Project: Derby
>          Issue Type: Bug
>          Components: JDBC
>    Affects Versions: 10.2.2.0, 10.3.0.0, 10.3.1.0, 10.4.0.0
>            Reporter: Daniel John Debrunner
>            Assignee: Kristian Waagan
>            Priority: Minor
>
> Only the jar files that contain the driver should have the autoloading services file for the JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.