[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8894: use single string dict and eliminate the integer key field

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8894:
URL: https://github.com/apache/pinot/pull/8894#discussion_r898606590


##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java:
##########
@@ -99,29 +97,32 @@ public class DataTableBuilder {
       new DataOutputStream(_variableSizeDataByteArrayOutputStream);
 
   private int _numRows;
+  private int _numDictionaryEntries;

Review Comment:
   This count is not accurate. It doesn't count the same value from different column



##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java:
##########
@@ -99,29 +97,32 @@ public class DataTableBuilder {
       new DataOutputStream(_variableSizeDataByteArrayOutputStream);
 
   private int _numRows;
+  private int _numDictionaryEntries;

Review Comment:
   For V4, let's directly update a single `Map<String, Integer>` dictionary and a String[] reverse dictionary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org