[GitHub] [incubator-devlake] Pranshu-Raj commented on a diff in pull request #2562: perf: added error handling missing code

[GitBox <gi...@apache.org>]

Pranshu-Raj commented on code in PR #2562:
URL: https://github.com/apache/incubator-devlake/pull/2562#discussion_r928095055


##########
plugins/tapd/api/connection.go:
##########
@@ -161,5 +161,8 @@ GET /plugins/tapd/connections/:connectionId
 func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) {
 	connection := &models.TapdConnection{}
 	err := connectionHelper.First(connection, input.Params)
-	return &core.ApiResourceOutput{Body: connection}, err
+	if err != nil {
+		return nil,err
+	}
+	return &core.ApiResourceOutput{Body: connection},nil

Review Comment:
   okay that i did previously but why this lint comments test is failing can u help me with that?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org