You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:51:29 UTC

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1372: ZOOKEEPER-3850: Update jUnit to 5.6 in pom.xml files

nkalmar commented on a change in pull request #1372:
URL: https://github.com/apache/zookeeper/pull/1372#discussion_r437190587



##########
File path: pom.xml
##########
@@ -641,7 +648,7 @@
              <showWarnings>true</showWarnings>
              <compilerArgs>
                <compilerArg>-Werror</compilerArg>
-               <compilerArg>-Xlint:deprecation</compilerArg>
+               <!--compilerArg>-Xlint:deprecation</compilerArg-->

Review comment:
       Why comment it out?
   Please just remove if not needed. But I think it is intentional to fail the build if we use deprecated code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org