You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "dongjiang1989 (via GitHub)" <gi...@apache.org> on 2025/11/24 06:06:36 UTC
[PR] feat: Add zookeeper discovery [apisix]
dongjiang1989 opened a new pull request, #12772:
URL: https://github.com/apache/apisix/pull/12772
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #3231 #6687
Add zookeeper discovery
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3688511010
Hi @dongjiang1989, following up on the previous review comments. Please let us know if you have any updates. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2583496791
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,209 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local schema = require("apisix.discovery.zookeeper.schema")
+local table = require("apisix.core.table")
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+ schema = schema.schema,
+}
+
+-- Global Configuration
+local local_conf
Review Comment:
It is recommended that the main process request the service instance from ZooKeeper and synchronize it to the worker processes via the shared dict.
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,209 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local schema = require("apisix.discovery.zookeeper.schema")
+local table = require("apisix.core.table")
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+ schema = schema.schema,
+}
+
+-- Global Configuration
+local local_conf
+-- Service Instance Cache（service_name -> {nodes, expire_time}）
+local instance_cache = core.lrucache.new({
+ ttl = 3600,
+ count = 1024
+})
+
+-- Timer Identifier
+local fetch_timer
+
+-- The instance list of a single service from ZooKeeper
+local function fetch_service_instances(conf, service_name)
+ -- 1. Init connect
+ local client, err = utils.new_zk_client(conf)
+ if not client then
+ return nil, err
+ end
+
+ -- 2. TODO: Create path
+ local service_path = conf.root_path .. "/" .. service_name
+ local ok, err = utils.create_zk_path(client, service_path)
+ if not ok then
+ utils.close_zk_client(client)
+ return nil, err
+ end
+
+ -- 3. All instance nodes under a service
+ local children, err = client:get_children(service_path)
+ if not children then
+ utils.close_zk_client(client)
+ if err == "not exists" then
+ log.warn("service path not exists: ", service_path)
+ return {}
+ end
+ log.error("get zk children failed: ", err)
+ return nil, err
+ end
+
+ -- 4. Parse the data of each instance node one by one
+ local instances = {}
+ for _, child in ipairs(children) do
+ local instance_path = service_path .. "/" .. child
+ local data, stat, err = client:get(instance_path)
+ if not data then
+ log.error("get instance data failed: ", instance_path, " stat:", stat, " err: ", err)
+ goto continue
+ end
+
+ -- Parse instance data
+ local instance = utils.parse_instance_data(data)
+ if instance then
+ table.insert(instances, instance)
+ end
+
+ ::continue::
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+
+ log.debug("fetch service instances: ", service_name, " count: ", #instances)
+ return instances
+end
+
+-- Scheduled fetch of all service instances (full cache update)）
+local function fetch_all_services()
+ if not local_conf then
+ log.warn("zookeeper discovery config not loaded")
+ return
+ end
+
+ -- 1. Init Zookeeper client
+ local client, err = utils.new_zk_client(local_conf)
+ if not client then
+ log.error("init zk client failed: ", err)
+ return
+ end
+
+ -- 2. All instance nodes under a service
+ local services, err = client:get_children(local_conf.root_path)
+ if not services then
+ utils.close_zk_client(client)
+ log.error("get zk root children failed: ", err)
+ return
+ end
+
+ -- 3. Fetch the instances of each service and update the cache
+ local now = ngx.time()
+ for _, service in ipairs(services) do
+ local instances, err = fetch_service_instances(local_conf, service)
+ if instances then
+ instance_cache:set(service, nil, {
+ nodes = instances,
+ expire_time = now + local_conf.cache_ttl
+ })
+ else
+ log.error("fetch service instances failed: ", service, " err: ", err)
+ end
+ end
+
+ -- 4. Close connects
+ utils.close_zk_client(client)
+end
+
+function _M.nodes(service_name)
+ if not service_name or service_name == "" then
+ log.error("service name is empty")
+ return nil
+ end
+
+ -- 1. Get from cache
+ local cache = instance_cache:get(service_name)
+ local now = ngx.time()
+
+ -- 2. If the cache is missed or expired, actively pull (the data)）
+ if not cache or cache.expire_time < now then
+ log.debug("cache miss or expired, fetch from zk: ", service_name)
+ local instances, err = fetch_service_instances(local_conf, service_name)
+ if not instances then
+ log.error("fetch instances failed: ", service_name, " err: ", err)
+ -- Fallback: Return the old cache (if available)）
+ if cache then
+ return cache.nodes
+ end
+ return nil
+ end
+
+ -- Update the cache
+ cache = {
+ nodes = instances,
+ expire_time = now + local_conf.cache_ttl
+ }
+ instance_cache:set(service_name, nil, cache)
+ end
+
+ return cache.nodes
+end
+
+function _M.check_schema(conf)
+ return schema.check(conf)
+end
+
+function _M.init_worker()
+ -- Load configuration
+ local core_config = core.config.local_conf
+ local_conf = core_config.discovery and core_config.discovery.zookeeper or {}
+ local ok, err = schema.check(local_conf)
+ if not ok then
+ log.error("invalid zookeeper discovery config: ", err)
+ return
+ end
+
+ -- The default values
+ local_conf.connect_string = local_conf.connect_string or "127.0.0.1:2181"
+ local_conf.fetch_interval = local_conf.fetch_interval or 10
+ local_conf.cache_ttl = local_conf.cache_ttl or 30
+
+ -- Start the timer
+ if not fetch_timer then
+ fetch_timer = ngx.timer.every(local_conf.fetch_interval, fetch_all_services)
+ log.info("zk discovery fetch timer started, interval: ", local_conf.fetch_interval, "s")
+ end
+
+ -- Manually execute a full pull immediately
+ ngx.timer.at(0, fetch_all_services)
+end
+
+function _M.destroy()
+ if fetch_timer then
+ fetch_timer = nil
+ end
+ instance_cache:flush_all()
+ log.info("zookeeper discovery destroyed")
+end
+
Review Comment:
A dump method is also needed to retrieve all services in the current service discovery instance. You can explore other service discovery modules for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3604872696
Hi @dongjiang1989, additional tests are needed to verify that the function works correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2634860483
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local lrucache = require("resty.lrucache")
+local table = require("apisix.core.table")
+local local_conf = require("apisix.core.config_local").local_conf()
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+}
+
+-- Global Configuration
+local zookeeper_conf
+-- Service Instance Cache（service_name -> {nodes, expire_time}）
+local instance_cache = lrucache.new(1024)
+
+-- Timer Identifier
+local fetch_timer
+
+-- The instance list of a single service from ZooKeeper
+local function fetch_service_instances(conf, service_name)
+ -- 1. Init connect
+ local client, err = utils.new_zk_client(conf)
+ if not client then
+ return nil, err
+ end
+
+ -- 2. Create path
+ local service_path = conf.root_path .. "/" .. service_name
+ local ok, err = utils.create_zk_path(client, service_path)
+ if not ok then
+ utils.close_zk_client(client)
+ return nil, err
+ end
+
+ -- 3. All instance nodes under a service
+ local children, err = client:get_children(service_path)
+ if not children then
+ utils.close_zk_client(client)
+ if err == "not exists" then
+ log.warn("service path not exists: ", service_path)
+ return {}
+ end
+ log.error("get zk children failed: ", err)
+ return nil, err
+ end
+
+ -- 4. Parse the data of each instance node one by one
+ local instances = {}
+ for _, child in ipairs(children) do
+ local instance_path = service_path .. "/" .. child
+ local data, stat, err = client:get_data(instance_path)
+ do
+ if not data then
+ log.error("get instance data failed: ", instance_path, " stat:", stat, " err: ", err)
+ break
+ end
+
+ -- Parse instance data
+ local instance = utils.parse_instance_data(data)
+ if instance then
+ table.insert(instances, instance)
+ end
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+
+ log.debug("fetch service instances: ", service_name, " count: ", #instances)
+ return instances
+end
+
+-- Scheduled fetch of all service instances (full cache update)）
+local function fetch_all_services()
+ if not zookeeper_conf then
+ log.warn("zookeeper discovery config not loaded")
+ return
+ end
+
+ -- 1. Init Zookeeper client
+ local client, err = utils.new_zk_client(zookeeper_conf)
+ if not client then
+ log.error("init zk client failed: ", err)
+ return
+ end
+
+ -- 2. Check instance root path exist
+ local ex, err = client:exists(zookeeper_conf.root_path)
+ if ex == false then
+ local created_parent, cerr = client:create(zookeeper_conf.root_path, "", "persistent", false)
+ if not created_parent then
+ utils.close_zk_client(client)
+ log.error("failed to create parent: ", cerr)
+ end
+ elseif err then
+ utils.close_zk_client(client)
+ log.error("exist zk root failed: ", err)
+ return
+ end
+
+ -- 3. All instance nodes under a service
+ local services, err = client:get_children(zookeeper_conf.root_path)
+ if not services then
+ utils.close_zk_client(client)
+ log.error("get zk root children failed: ", err)
+ return
+ end
+
+ -- 4. Fetch the instances of each service and update the cache
+ local now = ngx.time()
+ for _, service in ipairs(services) do
+ local instances, err = fetch_service_instances(zookeeper_conf, service)
+ if instances then
+ instance_cache:set(service, {
+ nodes = instances,
+ }, now + zookeeper_conf.cache_ttl)
+ else
+ log.error("fetch service instances failed: ", service, " err: ", err)
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+end
+
+function _M.nodes(service_name)
+ if not service_name or service_name == "" then
+ log.error("service name is empty")
+ return nil
+ end
+
+ -- 1. Check instance_cache initialized
+ if not instance_cache then
+ log.error("instance_cache not initialized")
+ return nil
+ end
+
+ -- 2. Get from cache
+ local cache, _, _ = instance_cache:get(service_name)
+ local now = ngx.time()
+
+ -- 3. If the cache is missed or expired, actively pull (the data)）
+ if not cache or cache.expire_time < now then
+ log.debug("cache miss or expired, fetch from zk: ", service_name)
+ local instances, err = fetch_service_instances(zookeeper_conf, service_name)
+ if not instances then
+ log.error("fetch instances failed: ", service_name, " err: ", err)
+ -- Fallback: Return the old cache (if available)）
+ if cache then
+ return cache.nodes
+ end
+ return nil
+ end
+
+ -- Update the cache
+ cache = {
+ nodes = instances,
+ }
+
+ instance_cache:set(service_name, cache, now + zookeeper_conf.cache_ttl)
+ end
+
+ return cache.nodes
+end
+
+function _M.init_worker()
+ -- Load configuration
+ zookeeper_conf = local_conf.discovery and local_conf.discovery.zookeeper or {}
+
+ -- The default values
+ zookeeper_conf.connect_string = zookeeper_conf.connect_string or "127.0.0.1:2181"
+ zookeeper_conf.fetch_interval = zookeeper_conf.fetch_interval or 10
+ zookeeper_conf.session_timeout = zookeeper_conf.session_timeout or 30000
+ zookeeper_conf.connect_timeout = zookeeper_conf.connect_timeout or 5000
+ zookeeper_conf.cache_ttl = zookeeper_conf.cache_ttl or 30
+ zookeeper_conf.root_path = zookeeper_conf.root_path or "/apisix/discovery/zk"
+ zookeeper_conf.auth = zookeeper_conf.auth or {type = "digest", creds = "",}
Review Comment:
Thanks @Baoyuantop
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3578835921
@Baoyuantop Please review docs, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #12772: feat(disvocery): Add zookeeper discovery
URL: https://github.com/apache/apisix/pull/12772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3573713335
> Hi @dongjiang1989, thanks for your contribution. Could you add documentation and testing for this feature? You can refer to other service discovery modules for reference.
Thanks @Baoyuantop
Documentation and Testing will coming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2633893406
##########
apisix/discovery/zookeeper/utils.lua:
##########
@@ -0,0 +1,112 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local zk = require("resty.zookeeper")
+local cjson = require("cjson.safe")
Review Comment:
Recommended use: local json = require("apisix.core.json")
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local lrucache = require("resty.lrucache")
+local table = require("apisix.core.table")
+local local_conf = require("apisix.core.config_local").local_conf()
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
Review Comment:
This is unnecessary.
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local lrucache = require("resty.lrucache")
+local table = require("apisix.core.table")
+local local_conf = require("apisix.core.config_local").local_conf()
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+}
+
+-- Global Configuration
+local zookeeper_conf
+-- Service Instance Cache（service_name -> {nodes, expire_time}）
+local instance_cache = lrucache.new(1024)
+
+-- Timer Identifier
+local fetch_timer
+
+-- The instance list of a single service from ZooKeeper
+local function fetch_service_instances(conf, service_name)
+ -- 1. Init connect
+ local client, err = utils.new_zk_client(conf)
+ if not client then
+ return nil, err
+ end
+
+ -- 2. Create path
+ local service_path = conf.root_path .. "/" .. service_name
+ local ok, err = utils.create_zk_path(client, service_path)
+ if not ok then
+ utils.close_zk_client(client)
+ return nil, err
+ end
+
+ -- 3. All instance nodes under a service
+ local children, err = client:get_children(service_path)
+ if not children then
+ utils.close_zk_client(client)
+ if err == "not exists" then
+ log.warn("service path not exists: ", service_path)
+ return {}
+ end
+ log.error("get zk children failed: ", err)
+ return nil, err
+ end
+
+ -- 4. Parse the data of each instance node one by one
+ local instances = {}
+ for _, child in ipairs(children) do
+ local instance_path = service_path .. "/" .. child
+ local data, stat, err = client:get_data(instance_path)
+ do
+ if not data then
+ log.error("get instance data failed: ", instance_path, " stat:", stat, " err: ", err)
+ break
+ end
+
+ -- Parse instance data
+ local instance = utils.parse_instance_data(data)
+ if instance then
+ table.insert(instances, instance)
+ end
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+
+ log.debug("fetch service instances: ", service_name, " count: ", #instances)
+ return instances
+end
+
+-- Scheduled fetch of all service instances (full cache update)）
+local function fetch_all_services()
Review Comment:
Do not fetch all services from ZooKeeper. This can cause significant network overhead when there are many services in ZooKeeper. It is recommended to refer to the Nacos implementation and use a timer to iterate through the currently configured Upstream, Route, and Service resources of APISIX, collecting all currently used service_names (with discovery_type set to zookeeper). Only perform ZooKeeper queries and cache updates on these "in-use" services.
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local lrucache = require("resty.lrucache")
+local table = require("apisix.core.table")
+local local_conf = require("apisix.core.config_local").local_conf()
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+}
+
+-- Global Configuration
+local zookeeper_conf
+-- Service Instance Cache（service_name -> {nodes, expire_time}）
+local instance_cache = lrucache.new(1024)
+
+-- Timer Identifier
+local fetch_timer
+
+-- The instance list of a single service from ZooKeeper
+local function fetch_service_instances(conf, service_name)
+ -- 1. Init connect
+ local client, err = utils.new_zk_client(conf)
+ if not client then
+ return nil, err
+ end
+
+ -- 2. Create path
+ local service_path = conf.root_path .. "/" .. service_name
+ local ok, err = utils.create_zk_path(client, service_path)
+ if not ok then
+ utils.close_zk_client(client)
+ return nil, err
+ end
+
+ -- 3. All instance nodes under a service
+ local children, err = client:get_children(service_path)
+ if not children then
+ utils.close_zk_client(client)
+ if err == "not exists" then
+ log.warn("service path not exists: ", service_path)
+ return {}
+ end
+ log.error("get zk children failed: ", err)
+ return nil, err
+ end
+
+ -- 4. Parse the data of each instance node one by one
+ local instances = {}
+ for _, child in ipairs(children) do
+ local instance_path = service_path .. "/" .. child
+ local data, stat, err = client:get_data(instance_path)
+ do
+ if not data then
+ log.error("get instance data failed: ", instance_path, " stat:", stat, " err: ", err)
+ break
+ end
+
+ -- Parse instance data
+ local instance = utils.parse_instance_data(data)
+ if instance then
+ table.insert(instances, instance)
+ end
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+
+ log.debug("fetch service instances: ", service_name, " count: ", #instances)
+ return instances
+end
+
+-- Scheduled fetch of all service instances (full cache update)）
+local function fetch_all_services()
+ if not zookeeper_conf then
+ log.warn("zookeeper discovery config not loaded")
+ return
+ end
+
+ -- 1. Init Zookeeper client
+ local client, err = utils.new_zk_client(zookeeper_conf)
+ if not client then
+ log.error("init zk client failed: ", err)
+ return
+ end
+
+ -- 2. Check instance root path exist
+ local ex, err = client:exists(zookeeper_conf.root_path)
+ if ex == false then
+ local created_parent, cerr = client:create(zookeeper_conf.root_path, "", "persistent", false)
+ if not created_parent then
+ utils.close_zk_client(client)
+ log.error("failed to create parent: ", cerr)
+ end
+ elseif err then
+ utils.close_zk_client(client)
+ log.error("exist zk root failed: ", err)
+ return
+ end
+
+ -- 3. All instance nodes under a service
+ local services, err = client:get_children(zookeeper_conf.root_path)
+ if not services then
+ utils.close_zk_client(client)
+ log.error("get zk root children failed: ", err)
+ return
+ end
+
+ -- 4. Fetch the instances of each service and update the cache
+ local now = ngx.time()
+ for _, service in ipairs(services) do
+ local instances, err = fetch_service_instances(zookeeper_conf, service)
+ if instances then
+ instance_cache:set(service, {
+ nodes = instances,
+ }, now + zookeeper_conf.cache_ttl)
+ else
+ log.error("fetch service instances failed: ", service, " err: ", err)
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+end
+
+function _M.nodes(service_name)
+ if not service_name or service_name == "" then
+ log.error("service name is empty")
+ return nil
+ end
+
+ -- 1. Check instance_cache initialized
+ if not instance_cache then
+ log.error("instance_cache not initialized")
+ return nil
+ end
+
+ -- 2. Get from cache
+ local cache, _, _ = instance_cache:get(service_name)
+ local now = ngx.time()
+
+ -- 3. If the cache is missed or expired, actively pull (the data)）
+ if not cache or cache.expire_time < now then
+ log.debug("cache miss or expired, fetch from zk: ", service_name)
+ local instances, err = fetch_service_instances(zookeeper_conf, service_name)
+ if not instances then
+ log.error("fetch instances failed: ", service_name, " err: ", err)
+ -- Fallback: Return the old cache (if available)）
+ if cache then
+ return cache.nodes
+ end
+ return nil
+ end
+
+ -- Update the cache
+ cache = {
+ nodes = instances,
+ }
+
+ instance_cache:set(service_name, cache, now + zookeeper_conf.cache_ttl)
+ end
+
+ return cache.nodes
+end
+
+function _M.init_worker()
+ -- Load configuration
+ zookeeper_conf = local_conf.discovery and local_conf.discovery.zookeeper or {}
+
+ -- The default values
+ zookeeper_conf.connect_string = zookeeper_conf.connect_string or "127.0.0.1:2181"
+ zookeeper_conf.fetch_interval = zookeeper_conf.fetch_interval or 10
+ zookeeper_conf.session_timeout = zookeeper_conf.session_timeout or 30000
+ zookeeper_conf.connect_timeout = zookeeper_conf.connect_timeout or 5000
+ zookeeper_conf.cache_ttl = zookeeper_conf.cache_ttl or 30
+ zookeeper_conf.root_path = zookeeper_conf.root_path or "/apisix/discovery/zk"
+ zookeeper_conf.auth = zookeeper_conf.auth or {type = "digest", creds = "",}
+ zookeeper_conf.weight = zookeeper_conf.weight or 100
+
+ log.info("zookeeper_conf:", core.json.encode(zookeeper_conf))
+ -- Start the timer
+ if not fetch_timer then
+ fetch_timer = ngx.timer.every(zookeeper_conf.fetch_interval, fetch_all_services)
Review Comment:
It is recommended that only privileged processes request data from ZooKeeper and write it to the shared dict, while other processes read the data from the shared dict.
##########
apisix/discovery/zookeeper/init.lua:
##########
@@ -0,0 +1,238 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local utils = require("apisix.discovery.zookeeper.utils")
+local lrucache = require("resty.lrucache")
+local table = require("apisix.core.table")
+local local_conf = require("apisix.core.config_local").local_conf()
+local ngx = ngx
+local ipairs = ipairs
+local log = core.log
+
+local _M = {
+ version = 0.1,
+ priority = 1000,
+ name = "zookeeper",
+}
+
+-- Global Configuration
+local zookeeper_conf
+-- Service Instance Cache（service_name -> {nodes, expire_time}）
+local instance_cache = lrucache.new(1024)
+
+-- Timer Identifier
+local fetch_timer
+
+-- The instance list of a single service from ZooKeeper
+local function fetch_service_instances(conf, service_name)
+ -- 1. Init connect
+ local client, err = utils.new_zk_client(conf)
+ if not client then
+ return nil, err
+ end
+
+ -- 2. Create path
+ local service_path = conf.root_path .. "/" .. service_name
+ local ok, err = utils.create_zk_path(client, service_path)
+ if not ok then
+ utils.close_zk_client(client)
+ return nil, err
+ end
+
+ -- 3. All instance nodes under a service
+ local children, err = client:get_children(service_path)
+ if not children then
+ utils.close_zk_client(client)
+ if err == "not exists" then
+ log.warn("service path not exists: ", service_path)
+ return {}
+ end
+ log.error("get zk children failed: ", err)
+ return nil, err
+ end
+
+ -- 4. Parse the data of each instance node one by one
+ local instances = {}
+ for _, child in ipairs(children) do
+ local instance_path = service_path .. "/" .. child
+ local data, stat, err = client:get_data(instance_path)
+ do
+ if not data then
+ log.error("get instance data failed: ", instance_path, " stat:", stat, " err: ", err)
+ break
+ end
+
+ -- Parse instance data
+ local instance = utils.parse_instance_data(data)
+ if instance then
+ table.insert(instances, instance)
+ end
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+
+ log.debug("fetch service instances: ", service_name, " count: ", #instances)
+ return instances
+end
+
+-- Scheduled fetch of all service instances (full cache update)）
+local function fetch_all_services()
+ if not zookeeper_conf then
+ log.warn("zookeeper discovery config not loaded")
+ return
+ end
+
+ -- 1. Init Zookeeper client
+ local client, err = utils.new_zk_client(zookeeper_conf)
+ if not client then
+ log.error("init zk client failed: ", err)
+ return
+ end
+
+ -- 2. Check instance root path exist
+ local ex, err = client:exists(zookeeper_conf.root_path)
+ if ex == false then
+ local created_parent, cerr = client:create(zookeeper_conf.root_path, "", "persistent", false)
+ if not created_parent then
+ utils.close_zk_client(client)
+ log.error("failed to create parent: ", cerr)
+ end
+ elseif err then
+ utils.close_zk_client(client)
+ log.error("exist zk root failed: ", err)
+ return
+ end
+
+ -- 3. All instance nodes under a service
+ local services, err = client:get_children(zookeeper_conf.root_path)
+ if not services then
+ utils.close_zk_client(client)
+ log.error("get zk root children failed: ", err)
+ return
+ end
+
+ -- 4. Fetch the instances of each service and update the cache
+ local now = ngx.time()
+ for _, service in ipairs(services) do
+ local instances, err = fetch_service_instances(zookeeper_conf, service)
+ if instances then
+ instance_cache:set(service, {
+ nodes = instances,
+ }, now + zookeeper_conf.cache_ttl)
+ else
+ log.error("fetch service instances failed: ", service, " err: ", err)
+ end
+ end
+
+ -- 5. Close connects
+ utils.close_zk_client(client)
+end
+
+function _M.nodes(service_name)
+ if not service_name or service_name == "" then
+ log.error("service name is empty")
+ return nil
+ end
+
+ -- 1. Check instance_cache initialized
+ if not instance_cache then
+ log.error("instance_cache not initialized")
+ return nil
+ end
+
+ -- 2. Get from cache
+ local cache, _, _ = instance_cache:get(service_name)
+ local now = ngx.time()
+
+ -- 3. If the cache is missed or expired, actively pull (the data)）
+ if not cache or cache.expire_time < now then
+ log.debug("cache miss or expired, fetch from zk: ", service_name)
+ local instances, err = fetch_service_instances(zookeeper_conf, service_name)
+ if not instances then
+ log.error("fetch instances failed: ", service_name, " err: ", err)
+ -- Fallback: Return the old cache (if available)）
+ if cache then
+ return cache.nodes
+ end
+ return nil
+ end
+
+ -- Update the cache
+ cache = {
+ nodes = instances,
+ }
+
+ instance_cache:set(service_name, cache, now + zookeeper_conf.cache_ttl)
+ end
+
+ return cache.nodes
+end
+
+function _M.init_worker()
+ -- Load configuration
+ zookeeper_conf = local_conf.discovery and local_conf.discovery.zookeeper or {}
+
+ -- The default values
+ zookeeper_conf.connect_string = zookeeper_conf.connect_string or "127.0.0.1:2181"
+ zookeeper_conf.fetch_interval = zookeeper_conf.fetch_interval or 10
+ zookeeper_conf.session_timeout = zookeeper_conf.session_timeout or 30000
+ zookeeper_conf.connect_timeout = zookeeper_conf.connect_timeout or 5000
+ zookeeper_conf.cache_ttl = zookeeper_conf.cache_ttl or 30
+ zookeeper_conf.root_path = zookeeper_conf.root_path or "/apisix/discovery/zk"
+ zookeeper_conf.auth = zookeeper_conf.auth or {type = "digest", creds = "",}
Review Comment:
We can handle default values in jsonschema; you can refer to the schemas of other service discovery components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2634861133
##########
apisix/discovery/zookeeper/utils.lua:
##########
@@ -0,0 +1,112 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local zk = require("resty.zookeeper")
+local cjson = require("cjson.safe")
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2558394173
##########
apisix/discovery/zookeeper/schema.lua:
##########
@@ -0,0 +1,91 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+
+local schema = {
+ type = "object",
+ properties = {
+ -- ZooKeeper Cluster Addresses (separated by commas for multiple addresses)
+ connect_string = {
+ type = "string",
+ default = "127.0.0.1:2181"
+ },
+ -- ZooKeeper Session Timeout (milliseconds)
+ session_timeout = {
+ type = "integer",
+ minimum = 1000,
+ default = 30000
+ },
+ -- ZooKeeper Connect Timeout (milliseconds)
+ connect_timeout = {
+ type = "integer",
+ minimum = 1000,
+ default = 5000
+ },
+ -- Service Discovery Root Path
+ root_path = {
+ type = "string",
+ default = "/apisix/discovery/zk"
+ },
+ -- Instance Fetch Interval (seconds)
+ fetch_interval = {
+ type = "integer",
+ minimum = 1,
+ default = 10
+ },
+ -- The default weight value for service instances that do not specify a weight in ZooKeeper.
+ -- It is used for load balancing (higher weight means more traffic).
+ -- Default value is 100, and the value range is 1-500.
+ weight = {
+ type = "integer",
+ minimum = 1,
+ default = 100
+ },
+ -- ZooKeeper Authentication Information (digest: username:password):
+ -- Digest authentication credentials for accessing ZooKeeper cluster.
+ -- Format requirement: "digest:{username}:{password}".
+ -- Leave empty to disable authentication (not recommended for production).
+ auth = {
+ type = "object",
+ properties = {
+ type = {type = "string", enum = {"digest"}, default = "digest"},
+ creds = {type = "string"} -- 格式: username:password
Review Comment:
Please use English.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on code in PR #12772:
URL: https://github.com/apache/apisix/pull/12772#discussion_r2558490773
##########
apisix/discovery/zookeeper/schema.lua:
##########
@@ -0,0 +1,91 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+
+local schema = {
+ type = "object",
+ properties = {
+ -- ZooKeeper Cluster Addresses (separated by commas for multiple addresses)
+ connect_string = {
+ type = "string",
+ default = "127.0.0.1:2181"
+ },
+ -- ZooKeeper Session Timeout (milliseconds)
+ session_timeout = {
+ type = "integer",
+ minimum = 1000,
+ default = 30000
+ },
+ -- ZooKeeper Connect Timeout (milliseconds)
+ connect_timeout = {
+ type = "integer",
+ minimum = 1000,
+ default = 5000
+ },
+ -- Service Discovery Root Path
+ root_path = {
+ type = "string",
+ default = "/apisix/discovery/zk"
+ },
+ -- Instance Fetch Interval (seconds)
+ fetch_interval = {
+ type = "integer",
+ minimum = 1,
+ default = 10
+ },
+ -- The default weight value for service instances that do not specify a weight in ZooKeeper.
+ -- It is used for load balancing (higher weight means more traffic).
+ -- Default value is 100, and the value range is 1-500.
+ weight = {
+ type = "integer",
+ minimum = 1,
+ default = 100
+ },
+ -- ZooKeeper Authentication Information (digest: username:password):
+ -- Digest authentication credentials for accessing ZooKeeper cluster.
+ -- Format requirement: "digest:{username}:{password}".
+ -- Leave empty to disable authentication (not recommended for production).
+ auth = {
+ type = "object",
+ properties = {
+ type = {type = "string", enum = {"digest"}, default = "digest"},
+ creds = {type = "string"} -- 格式: username:password
Review Comment:
Thanks @Baoyuantop
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "dongjiang1989 (via GitHub)" <gi...@apache.org>.
dongjiang1989 commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3669468621
> Hi @dongjiang1989, any update?
Thanks @Baoyuantop
Update. Please re-check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3948456666
Hi @dongjiang1989, following up on the previous review comments. Please let us know if you have any updates. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-4295471828
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3940631081
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(disvocery): Add zookeeper discovery [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #12772:
URL: https://github.com/apache/apisix/pull/12772#issuecomment-3659409943
Hi @dongjiang1989, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org