You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2018/08/02 19:52:20 UTC

Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-2172
    https://issues.apache.org/jira/browse/RANGER-2172


Repository: ranger


Description
-------

Changed code to read only STRLEN-1 characters using sscanf in order to correctly accommodate the array size.


Diffs
-----

  unixauthnative/src/main/c/credValidator.c 189c2ca5e 
  unixauthpam/src/main/c/pamCredValidator.c 8e3690301 


Diff: https://reviews.apache.org/r/68170/diff/1/


Testing
-------

Tested manually from command line.


Thanks,

Sailaja Polavarapu


Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

Posted by Selvamohan Neethiraj <sn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206821
-----------------------------------------------------------


Ship it!




Ship It!

- Selvamohan Neethiraj


On Aug. 2, 2018, 3:52 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2018, 3:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
>     https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to correctly accommodate the array size.
> 
> 
> Diffs
> -----
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206822
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Aug. 2, 2018, 7:52 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2018, 7:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
>     https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to correctly accommodate the array size.
> 
> 
> Diffs
> -----
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Re: Review Request 68170: RANGER-2172: Fixing minor issue with the no. of characters read using sscanf

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68170/#review206820
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Aug. 2, 2018, 7:52 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68170/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2018, 7:52 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2172
>     https://issues.apache.org/jira/browse/RANGER-2172
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Changed code to read only STRLEN-1 characters using sscanf in order to correctly accommodate the array size.
> 
> 
> Diffs
> -----
> 
>   unixauthnative/src/main/c/credValidator.c 189c2ca5e 
>   unixauthpam/src/main/c/pamCredValidator.c 8e3690301 
> 
> 
> Diff: https://reviews.apache.org/r/68170/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually from command line.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>