You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/06/06 16:52:28 UTC

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7211: GEODE-10354: Convert enum like classes to enum.

demery-pivotal commented on code in PR #7211:
URL: https://github.com/apache/geode/pull/7211#discussion_r890343844


##########
geode-dunit/src/main/java/org/apache/geode/cache30/RegionTestCase.java:
##########
@@ -3736,7 +3736,7 @@ private void remoteTestPostSnapshot(String name, boolean isController, boolean i
 
     boolean expectData =
         isController || postSnapshotRegion.getAttributes().getMirrorType().isMirrored()

Review Comment:
   Can `getMirrorType().isMirrored()` be replaced with information from the `DataPolicy`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org