You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tvm.apache.org by Lixiaoquan via Apache TVM Discuss <no...@discuss.tvm.ai> on 2020/11/11 07:46:06 UTC
[Apache TVM Discuss] [Development/RFC] Expand Span for imported
module
In this PR https://github.com/apache/incubator-tvm/pull/6885, node name is stored in Span.SourceName.
Since Span.SourceName is supposed to represent name of source file, I'd suggest to add another field `hint` to Span to represent node or layer name which is common in models.
And when model is imported, its name isn't kept by frontend, so Span.SourceName will be left empty in that case. `line`, `colume`, `end_line` and `end_colume` aren't needed too for imported model.
@joshua19881228 @jroesch @tqchen @FrozenGene Please share your thought
---
[Visit Topic](https://discuss.tvm.apache.org/t/expand-span-for-imported-module/8435/1) to respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/8798b0e796b8bf2340e3d238669a6923e861571f285f0620cc40da72bb754a2f).
[Apache TVM Discuss] [Development/RFC] Expand Span for imported
module
Posted by Tristan Konolige via Apache TVM Discuss <no...@discuss.tvm.ai>.
@jroesch and I were talking about this a little. We were thinking of subclassing Span. You'd have SourceSpan which comes from files and then ModelSpan (probably could use a better name) for handling layers/nodes in models. This gets around the issue of having meaningless line fields for spans from models.
---
[Visit Topic](https://discuss.tvm.apache.org/t/expand-span-for-imported-module/8435/3) to respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/0396fda4f097d9eafc2aeb5724e7d5b94b039911eca542a59f2f2d7f5e92b029).
[Apache TVM Discuss] [Development/RFC] Expand Span for imported
module
Posted by Zhao Wu via Apache TVM Discuss <no...@discuss.tvm.ai>.
I would like to add one `flags` attribute to make us have more extension for the future. Like we could have `Span: (sourcename: ..., line:... column:... flags: SPFlagSourceNameImportedFromModel, ...)` Then we could query the flags attribute to handle the specific condition.
---
[Visit Topic](https://discuss.tvm.apache.org/t/expand-span-for-imported-module/8435/2) to respond.
You are receiving this because you enabled mailing list mode.
To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/e5d92fa5a65c2c6a88f47203150eef4286ea352856277ca1ba3794a07fc74f84).