[GitHub] [spark] gatorsmile commented on issue #25114: [SPARK-28349][SQL] Add FALSE and SETMINUS to ansiNonReserved

[GitBox <gi...@apache.org>]

gatorsmile commented on issue #25114: [SPARK-28349][SQL] Add FALSE and SETMINUS to ansiNonReserved
URL: https://github.com/apache/spark/pull/25114#issuecomment-511062533
 
 
   First, FALSE is reserved word. 
   
   Second, see https://www.postgresql.org/docs/7.3/sql-keywords-appendix.html
   
   > In the PostgreSQL parser life is a bit more complicated. There are several different classes of tokens ranging from those that can never be used as an identifier to those that have absolutely no special status in the parser as compared to an ordinary identifier. (The latter is usually the case for functions specified by SQL.) Even reserved key words are not completely reserved in PostgreSQL, but can be used as column labels (for example, SELECT 55 AS CHECK, even though CHECK is a reserved key word).
   
   We do not need to follow PostgreSQL to support reserved words in column alias.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org