You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by "xubo245 (via GitHub)" <gi...@apache.org> on 2023/04/09 07:05:17 UTC

[GitHub] [carbondata] xubo245 opened a new pull request, #4307: [ISSUE-4305] Optimize the magic number

xubo245 opened a new pull request, #4307:
URL: https://github.com/apache/carbondata/pull/4307

    ### Why is this PR needed?
    There are some code style, which should be optimized
    
    ### What changes were proposed in this PR?
   optimize the magic code in example 
       
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No, only change the example
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [carbondata] chenliang613 merged pull request #4307: [ISSUE-4305] Optimize the magic number

Posted by "chenliang613 (via GitHub)" <gi...@apache.org>.
chenliang613 merged PR #4307:
URL: https://github.com/apache/carbondata/pull/4307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4307:
URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074867

   Build Failed  with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4671/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [carbondata] chenliang613 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

Posted by "chenliang613 (via GitHub)" <gi...@apache.org>.
chenliang613 commented on PR #4307:
URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501064484

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4307:
URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074932

   Build Failed  with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/762/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [carbondata] shenjiayu17 commented on pull request #4307: [ISSUE-4305] Optimize the magic number

Posted by "shenjiayu17 (via GitHub)" <gi...@apache.org>.
shenjiayu17 commented on PR #4307:
URL: https://github.com/apache/carbondata/pull/4307#issuecomment-1501074813

   Build Failed  with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6379/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org