You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mehrdad Nurolahzade <me...@nurolahzade.com> on 2017/01/12 23:07:53 UTC
Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter runs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55477/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1874
https://issues.apache.org/jira/browse/AURORA-1874
Repository: aurora
Description
-------
AURORA-1874 Expose stats on SlotSizeCounter runs
Diffs
-----
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java d0cc72f98f7b31c469505846e8cfc9c3bcf05ed0
Diff: https://reviews.apache.org/r/55477/diff/
Testing
-------
Thanks,
Mehrdad Nurolahzade
Re: Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter
runs
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55477/#review161576
-----------------------------------------------------------
Master (06a221f) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 12, 2017, 11:07 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55477/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 11:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1874
> https://issues.apache.org/jira/browse/AURORA-1874
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1874 Expose stats on SlotSizeCounter runs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java d0cc72f98f7b31c469505846e8cfc9c3bcf05ed0
>
> Diff: https://reviews.apache.org/r/55477/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter
runs
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55477/#review161575
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 12, 2017, 3:07 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55477/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 3:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1874
> https://issues.apache.org/jira/browse/AURORA-1874
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1874 Expose stats on SlotSizeCounter runs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java d0cc72f98f7b31c469505846e8cfc9c3bcf05ed0
>
> Diff: https://reviews.apache.org/r/55477/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter
runs
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55477/#review161451
-----------------------------------------------------------
Master (06a221f) is red with this patch.
./build-support/jenkins/build.sh
thrift-0.9.1/tutorial/py/Makefile.in
thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
Makefile:49: recipe for target 'thrift-0.9.1/compiler/cpp/thrift' failed
make: Leaving directory '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
:api:generateThriftJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 11.556 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 12, 2017, 11:07 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55477/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 11:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1874
> https://issues.apache.org/jira/browse/AURORA-1874
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1874 Expose stats on SlotSizeCounter runs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java d0cc72f98f7b31c469505846e8cfc9c3bcf05ed0
>
> Diff: https://reviews.apache.org/r/55477/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>
Re: Review Request 55477: AURORA-1874 Expose stats on SlotSizeCounter
runs
Posted by Mehrdad Nurolahzade <me...@nurolahzade.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55477/#review161572
-----------------------------------------------------------
@ReviewBot retry
- Mehrdad Nurolahzade
On Jan. 12, 2017, 3:07 p.m., Mehrdad Nurolahzade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55477/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 3:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1874
> https://issues.apache.org/jira/browse/AURORA-1874
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-1874 Expose stats on SlotSizeCounter runs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java d0cc72f98f7b31c469505846e8cfc9c3bcf05ed0
>
> Diff: https://reviews.apache.org/r/55477/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mehrdad Nurolahzade
>
>