You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/25 11:50:17 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #4367: [document][swagger]Update topics rest api document

sijie commented on a change in pull request #4367: [document][swagger]Update topics rest api document
URL: https://github.com/apache/pulsar/pull/4367#discussion_r287554701
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
 ##########
 @@ -68,7 +69,11 @@
     @ApiOperation(value = "Get the list of topics under a namespace.", response = String.class, responseContainer = "List")
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
             @ApiResponse(code = 404, message = "Namespace doesn't exist") })
 
 Review comment:
   `validateNamespaceName` will throw `PRECONDITION_FAILED (412)` exception. can you please update the response list?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services