You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2020/04/15 19:47:53 UTC

[kudu-CR] [cfile] Add EncodingTraits to remove boiler plate code in type encodings.cc

Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15722

to look at the new patch set (#3).

Change subject: [cfile] Add EncodingTraits to remove boiler plate code in type_encodings.cc
......................................................................

[cfile] Add EncodingTraits to remove boiler plate code in type_encodings.cc

This diff includes no functional change.

Change-Id: Ie01865756713b4a1f75a4e1574080ff892671386
---
M src/kudu/cfile/type_encodings.cc
1 file changed, 42 insertions(+), 111 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/15722/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15722
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie01865756713b4a1f75a4e1574080ff892671386
Gerrit-Change-Number: 15722
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>