[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4152: Fix the issue where ZkCacheBaseDataAccessor.getChildren() can return list with null znRecords

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4152: Fix the issue where ZkCacheBaseDataAccessor.getChildren() can return list with null znRecords
URL: https://github.com/apache/incubator-pinot/pull/4152#discussion_r277515177
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
 ##########
 @@ -297,70 +297,88 @@ public static Schema getTableSchema(@Nonnull ZkHelixPropertyStore<ZNRecord> prop
    */
   public static List<OfflineSegmentZKMetadata> getOfflineSegmentZKMetadataListForTable(
       ZkHelixPropertyStore<ZNRecord> propertyStore, String tableName) {
 
 Review comment:
   There was a discussion before about how to use the **@Nullable** and **@NonNull** annotation. Because almost all arguments should be non-null, we decide to only use **@Nullable** annotation to mark arguments or return value that could be null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org