You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/06/12 07:08:01 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #4471:
[pulsar-broker] add cli/admin api to delete bookie-affinity group
Anonymitaet commented on a change in pull request #4471: [pulsar-broker] add cli/admin api to delete bookie-affinity group
URL: https://github.com/apache/pulsar/pull/4471#discussion_r292771166
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
##########
@@ -575,7 +575,19 @@ public BookieAffinityGroupData getBookieAffinityGroup(@PathParam("property") Str
validateNamespaceName(property, cluster, namespace);
return internalGetBookieAffinityGroup();
}
-
+
+ @DELETE
+ @Path("/{property}/{cluster}/{namespace}/persistence/bookieAffinity")
+ @ApiOperation(hidden = true, value = "Delete the bookie-affinity-group from namespace-local policy.")
+ @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
Review comment:
Add a period.
Please check all similar cases in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services