You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/09 21:07:33 UTC

[GitHub] [spark] attilapiros commented on a change in pull request #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host

attilapiros commented on a change in pull request #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host
URL: https://github.com/apache/spark/pull/25299#discussion_r312648323
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
 ##########
 @@ -344,6 +348,7 @@ class ShuffleReadMetricDistributions private[spark](
     val readRecords: IndexedSeq[Double],
     val remoteBlocksFetched: IndexedSeq[Double],
     val localBlocksFetched: IndexedSeq[Double],
+    val hostLocalBlocksFetched: IndexedSeq[Double],
 
 Review comment:
   Regarding this PR the disk caching of SHS problem is not relevant as the metric changes are reverted but I still would like to check whether the problem already exists between 2.4 and 3.0 and fix if there is any issue. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org