[jira] [Commented] (BEAM-924) Findbugs doesn't pass in Direct Runner

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652087#comment-15652087 ] 

ASF GitHub Bot commented on BEAM-924:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1325

    [BEAM-924] Fix FindBugs Errors in the Direct Runner

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    Fixes the last three FindBugs bugs - implements `Serializable` in the two defined
    Comparators, and makes it impossible for the `visibleUpdates` queue to ever refuse
    to receive an offered element.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam findbugs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1325
    
----
commit a8025e9827c4491735f1460a7ab65cbb6200aa77
Author: Thomas Groh <tg...@google.com>
Date:   2016-11-09T21:24:19Z

    Fix FindBugs Errors in the Direct Runner

----


> Findbugs doesn't pass in Direct Runner
> --------------------------------------
>
>                 Key: BEAM-924
>                 URL: https://issues.apache.org/jira/browse/BEAM-924
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Daniel Halperin
>            Assignee: Thomas Groh
>
> {code}
> [INFO] AggregatorContainer$AggregatorInfo.accumulator not guarded against concurrent access; locked 71% of time [org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo, org.apache.beam.runners.direct.AggregatorContainer$AggregatorInfo] Unsynchronized access at AggregatorContainer.java:[line 80]Unsynchronized access at AggregatorContainer.java:[line 79]Unsynchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 78]Synchronized access at AggregatorContainer.java:[line 79]Synchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 81]Synchronized access at AggregatorContainer.java:[line 59]Synchronized access at AggregatorContainer.java:[line 62]Synchronized access at AggregatorContainer.java:[line 62]Synchronized access at AggregatorContainer.java:[line 60]Synchronized access at AggregatorContainer.java:[line 66]Synchronized access at AggregatorContainer.java:[line 66]
> [INFO] bundle must be non-null but is marked as nullable [org.apache.beam.runners.direct.ExecutorServiceParallelExecutor] At ExecutorServiceParallelExecutor.java:[lines 185-186]
> [INFO] Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable.run() [org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable] At ExecutorServiceParallelExecutor.java:[line 412]
> [INFO] org.apache.beam.runners.direct.WatermarkCallbackExecutor$CallbackOrdering implements Comparator but not Serializable [org.apache.beam.runners.direct.WatermarkCallbackExecutor$CallbackOrdering] At WatermarkCallbackExecutor.java:[lines 132-138]
> [INFO] org.apache.beam.runners.direct.WatermarkManager$WindowedValueByTimestampComparator implements Comparator but not Serializable [org.apache.beam.runners.direct.WatermarkManager$WindowedValueByTimestampComparator] At WatermarkManager.java:[lines 1380-1385]
> [INFO] 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)