You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "David Waite (JIRA)" <ji...@apache.org> on 2008/03/10 23:37:07 UTC
[jira] Created: (WW-2544) FileUploadInterceptor depends on
implementation of MultiPartRequestWrapper
FileUploadInterceptor depends on implementation of MultiPartRequestWrapper
--------------------------------------------------------------------------
Key: WW-2544
URL: https://issues.apache.org/struts/browse/WW-2544
Project: Struts 2
Issue Type: Bug
Components: Core Interceptors
Affects Versions: 2.0.11.1
Reporter: David Waite
The FileUploadInterceptor depends on the class/implementation of MultiPartRequestWrapper. This has become an issue with my efforts to wrap the HttpServletRequest as part of an authentication interceptor (made an interceptor to access annotations on the action class/method).
The wrapper is not an interface, which makes it difficult to capture and delegate to the framework-created instance. In addition, the wrapper does not retain the properties of the HttpServletRequestWrapper, i.e. I cannot simply subclass and pass an existing MultiPartRequestWrapper-ish type in to add or override functionality. As far as I can tell, either I subclass it to make a true wrapper (delegating all methods to the input request) or I have to change the logic that creates the MultiPartRequestWrapper to instead create a subtype that gives me a setUserPrincipal method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2544) FileUploadInterceptor depends on
implementation of MultiPartRequestWrapper
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2544:
--------------------------
Fix Version/s: Future
Issue Type: Improvement (was: Bug)
> FileUploadInterceptor depends on implementation of MultiPartRequestWrapper
> --------------------------------------------------------------------------
>
> Key: WW-2544
> URL: https://issues.apache.org/struts/browse/WW-2544
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.0.11.1
> Reporter: David Waite
> Fix For: Future
>
>
> The FileUploadInterceptor depends on the class/implementation of MultiPartRequestWrapper. This has become an issue with my efforts to wrap the HttpServletRequest as part of an authentication interceptor (made an interceptor to access annotations on the action class/method).
> The wrapper is not an interface, which makes it difficult to capture and delegate to the framework-created instance. In addition, the wrapper does not retain the properties of the HttpServletRequestWrapper, i.e. I cannot simply subclass and pass an existing MultiPartRequestWrapper-ish type in to add or override functionality. As far as I can tell, either I subclass it to make a true wrapper (delegating all methods to the input request) or I have to change the logic that creates the MultiPartRequestWrapper to instead create a subtype that gives me a setUserPrincipal method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2544) FileUploadInterceptor depends on
implementation of MultiPartRequestWrapper
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43984#action_43984 ]
James Holmes commented on WW-2544:
----------------------------------
If you'd like to see this implemented, a patch will go a long way in moving things along.
> FileUploadInterceptor depends on implementation of MultiPartRequestWrapper
> --------------------------------------------------------------------------
>
> Key: WW-2544
> URL: https://issues.apache.org/struts/browse/WW-2544
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.0.11.1
> Reporter: David Waite
> Fix For: Future
>
>
> The FileUploadInterceptor depends on the class/implementation of MultiPartRequestWrapper. This has become an issue with my efforts to wrap the HttpServletRequest as part of an authentication interceptor (made an interceptor to access annotations on the action class/method).
> The wrapper is not an interface, which makes it difficult to capture and delegate to the framework-created instance. In addition, the wrapper does not retain the properties of the HttpServletRequestWrapper, i.e. I cannot simply subclass and pass an existing MultiPartRequestWrapper-ish type in to add or override functionality. As far as I can tell, either I subclass it to make a true wrapper (delegating all methods to the input request) or I have to change the logic that creates the MultiPartRequestWrapper to instead create a subtype that gives me a setUserPrincipal method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2544) FileUploadInterceptor depends on
implementation of MultiPartRequestWrapper
Posted by "Musachy Barroso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Musachy Barroso resolved WW-2544.
---------------------------------
Resolution: Won't Fix
Feel free to re-open with a patch.
> FileUploadInterceptor depends on implementation of MultiPartRequestWrapper
> --------------------------------------------------------------------------
>
> Key: WW-2544
> URL: https://issues.apache.org/struts/browse/WW-2544
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Interceptors
> Affects Versions: 2.0.11.1
> Reporter: David Waite
> Fix For: Future
>
>
> The FileUploadInterceptor depends on the class/implementation of MultiPartRequestWrapper. This has become an issue with my efforts to wrap the HttpServletRequest as part of an authentication interceptor (made an interceptor to access annotations on the action class/method).
> The wrapper is not an interface, which makes it difficult to capture and delegate to the framework-created instance. In addition, the wrapper does not retain the properties of the HttpServletRequestWrapper, i.e. I cannot simply subclass and pass an existing MultiPartRequestWrapper-ish type in to add or override functionality. As far as I can tell, either I subclass it to make a true wrapper (delegating all methods to the input request) or I have to change the logic that creates the MultiPartRequestWrapper to instead create a subtype that gives me a setUserPrincipal method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.