You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by MJJoyce <gi...@git.apache.org> on 2014/05/19 17:58:07 UTC
[GitHub] climate pull request: Climate 370 - Update Easy OCW
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/29
Climate 370 - Update Easy OCW
This is an initial reworking of easy-ocw. Simple bash scripts are being used in lieu of buildout. Now that the dependencies are much easier to install, the added complexity of buildout isn't really necessary. There are still quite a few improvements to add to these and I'll be making relevant JIRAs in a bit to track them. These changes should cover fairly basic use cases. The OS X install script has been tested on a 10.9.2 box and 10.8.5 box. The Ubuntu install script has been tested on a clean 12.04 box using Vagrant.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit 9353d89c3ff23082df69d4e3b998d5905b66a25f
Author: Michael Joyce <jo...@apache.org>
Date: 2014-05-12T17:40:36Z
CLIMATE-370 - Add conda dependencies file
- Add ocw-conda-dependencies to simply conda install of OCW
dependencies. Any packages that should be conda installed can be listed
here and they will be picked up by the install scripts (assuming they
use this file).
commit 41e12989e8bf66eace60b6276e1d65813b545768
Author: Michael Joyce <jo...@apache.org>
Date: 2014-05-12T17:40:48Z
CLIMATE-370 - Add OS X install script
- Add OS X helper install script. Note that this uses the conda
dependencies file for installation of some of the components. At the
moment, specific versions aren't grabbed (just the latest versions of
the components are).
commit 629630a9c36c960c92671cd00a01908f2440040d
Author: Michael Joyce <jo...@apache.org>
Date: 2014-05-19T14:30:41Z
CLIMATE-370 - Add Ubuntu 12.04 helper install script
- Add Ubuntu 12.04 helper install script. Due to a problem encountered
using conda to install dependencies, the Anaconda Python distribution
is used instead. For the most part, this just means that additional
dependencies that aren't 100% necessary are downloaded as well.
- The Anaconda distribution that is used needs to be "versioned" at some
level to ensure that new versions of the libraries don't break toolkit
functionality.
- Further testing needs to be done to make the conda install work so
that there is minimal difference between the OS X and Ubuntu install
scripts.
commit fccf47f5b10916eec9b77cf8e17e960bb87144f0
Author: Michael Joyce <jo...@apache.org>
Date: 2014-05-19T15:34:48Z
CLIMATE-370 - Remove old easy-ocw Buildout code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-370 - Update Easy OCW
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/climate/pull/29#issuecomment-43571116
Hey Mike. I fetched your PR locally and ran the easy-ocw script. First and foremost... good work, this quickens installation to a fraction of the time it was taking before and is exactly what climate needed.
Please see my comments below regarding my initial observations of the log output. I've attached my log output to JIRA Issues CLIMATE-370 so you can see it there.
First though, for others, Mikes patch can be fetched and applied locally as follows
https://help.github.com/articles/checking-out-pull-requests-locally
*1*
```
Installing collected packages: conda, pycosat, pyyaml
Running setup.py install for conda
changing mode of build/scripts-2.7/conda from 644 to 755
error: could not create '/Library/Python/2.7/site-packages/conda': Permission denied
```
Is it a prerequisite to be logged in as sudo to successfully access offending Python directory and install? If so then we need to document this... possibly within the initial message prompt provided when one invokes the script (I've only run the macosx script so far Mike).
*2*
```
error: /Library/Python/2.7/site-packages/bottle.py: Permission denied
```
Same as above?
*3*
Many instances of the following
```
warning: no previously-included files matching '*' found under directory 'docs/_build/_sources'
warning: no files found matching '*.js' under directory 'paste'
warning: no files found matching '*.jpg' under directory 'paste'
```
I don not actually think that these are problems as they are warnings. If this is the case however can we suppress them somehow?
*4*
```
clang: warning: unknown argument: '-mno-fused-madd' [-Wunused-command-line-argument-hard-error-in-future]
clang: note: this will be a hard error (cannot be downgraded to a warning) in the future
clang: warning: argument unused during compilation: '-mno-fused-madd'
```
I am out of suggestions for this one... I do not have a shovel large enough to dig this up right now. Any ideas?
*5*
```
error: could not create '/Library/Python/2.7/site-packages/webtest': Permission denied
```
Same as 1 & 2 ?
*6*
```
no previously-included directories found matching 'doc/.build'
Installing collected packages: nose
Running setup.py install for nose
error: could not create '/Library/Python/2.7/site-packages/nose': Permission denied
```
... and again
*7*
```
error: could not create '/Library/Python/2.7/site-packages/pylint': Permission denied
```
enough already ;)
*8* The install script does not specify whether the install process was successful. It would be really nice to see some kind of verification that a successful (or unsuccessful) build took place.
Thanks Mike very much for working on this. Great job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-370 - Update Easy OCW
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/29#issuecomment-43541971
Updating the name to see if the mirror to JIRA will be fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-370 - Update Easy OCW
Posted by MJJoyce <gi...@git.apache.org>.
Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/29#issuecomment-43632364
@lewismc, if you don't run this script with -e (per the recommendation in the initial header) or you don't run it in a virtualenv environment then you will run need to run it as sudo on OS X. Of course, that's assuming that you don't have any other Python around that isn't the system Python. You shouldn't have any problems if you run it in a virtualenv on OS X without sudo, but if you run into any let me know. Either way, that will be made explicit in the wiki page that I'm writing.
Re. 3, I don't see the point in suppressing what's output to the log. The log is mostly for debugging. The average user wont ever need to look at it. If that stuff is getting dumped to stdout, then yes I think it should be suppressed (mostly by being sent to the log).
4 you can ignore. It's a issue with clang on OS X and the warnings are an artifact of the config flag set before installation. If you aren't seeing those you should be concerned, namely because clang will then elevate them to errors and all your builds will fail =)
Re. 8, we could print some message about the installation completing. But I'm not a fan of printing that it was successful unless we actually validate the install. There's nothing more annoying than seeing the message when something actually failed. I'll make a note of it and add it to the list of JIRAs I'm going to make once I merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-370 - Update Easy OCW
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---