You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/18 20:00:47 UTC
[GitHub] [airflow] potiuk opened a new pull request #7207: [AIRFLOW-XXXX]
Consistency fixes in new documentation
potiuk opened a new pull request #7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
URL: https://github.com/apache/airflow/pull/7207
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
URL: https://github.com/apache/airflow/pull/7207#discussion_r368290611
##########
File path: CONTRIBUTING.rst
##########
@@ -155,16 +155,16 @@ these guidelines:
Airflow Git Branches
====================
-All new development in Airflow happens in ``master`` branch. All PRs should target that branch.
-We also have ``v1-10-test`` branch which is used to test ``1.10.x`` series of Airflow and where committers
+All new development in Airflow happens in the ``master`` branch. All PRs should target that branch.
+We also have a ``v1-10-test`` branch that is used to test ``1.10.x`` series of Airflow and where committers
(and only committers) cherry-pick selected commits from the master branch.
Review comment:
```suggestion
cherry-pick selected commits from the master branch.
```
Just feels better imho.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7207: [AIRFLOW-XXXX]
Consistency fixes in new documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
URL: https://github.com/apache/airflow/pull/7207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7207: [AIRFLOW-XXXX]
Consistency fixes in new documentation
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
URL: https://github.com/apache/airflow/pull/7207#issuecomment-576220729
Mergeable fails :)
❌ Must include description for the PR
Input : ---
Issue link: Document only change, no JIRA issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7207:
[AIRFLOW-XXXX] Consistency fixes in new documentation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7207: [AIRFLOW-XXXX] Consistency fixes in new documentation
URL: https://github.com/apache/airflow/pull/7207#discussion_r368283262
##########
File path: CONTRIBUTING.rst
##########
@@ -341,16 +341,16 @@ itself comes bundled with jQuery and bootstrap. While they may be phased out
over time, these packages are currently not managed with yarn.
Make sure you are using recent versions of node and yarn. No problems have been
-found with node\>=8.11.3 and yarn\>=1.19.1
+found with node\>=8.11.3 and yarn\>=1.19.1.
-Installing yarn and its packages
--------------------------------
+Install yarn and Its Packages
+-----------------------------
Make sure yarn is available in your environment.
-To install it on macOS:
+To install yarn on macOS:
-1. Run the following commands (taken from `this source <https://gist.github.com/DanHerbert/9520689>`__):
+1. Run the install commands (taken from `this source <https://gist.github.com/DanHerbert/9520689>`__):
Review comment:
```suggestion
1. Run the following commands (taken from `this source <https://gist.github.com/DanHerbert/9520689>`__):
```
Let's keep "following" as it has a command to set config too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services