You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Mark Struberg <st...@yahoo.de> on 2013/05/27 09:36:47 UTC
asm4 in xbean
Hi!
A small discussion which popped up on IRC regarding asm4:
Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same packages.
For preventing some classpath clashes this xbean-asm-shaded package got created. This was ASM3 so far.
When moving up to ASM4 we should thus change the package we shade it in, e.g. to org.apache.xbean.asm4.*
I think there is common agreement on this point, right?
I've added a new module of xbean-asm4-shaded which uses ASM4 and shades to the aforementioned path.
But what to do with the asm3 shade?
We now have two options:
Do we like to
1.) keep both
or do we like to
2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and only keep xbean-asm4-shaded)?
2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I perso don't like this much as it is not so explicit for users.
LieGrue,
strub
Re: asm4 in xbean
Posted by Ivan <xh...@gmail.com>.
The most change I could see is for Java 7 support.
2013/5/27 Jean-Louis MONTEIRO <je...@gmail.com>
> Out of curiosity, what are the objectives of such a change?
> I mean, is there any important improvments on ASM4 we cannot miss?
> Is ASM 3 end of life?
>
> Jean-Louis
>
>
>
> 2013/5/27 Mark Struberg <st...@yahoo.de>
>
>> Hi!
>>
>> A small discussion which popped up on IRC regarding asm4:
>>
>> Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same
>> packages.
>> For preventing some classpath clashes this xbean-asm-shaded package got
>> created. This was ASM3 so far.
>>
>> When moving up to ASM4 we should thus change the package we shade it in,
>> e.g. to org.apache.xbean.asm4.*
>> I think there is common agreement on this point, right?
>>
>> I've added a new module of xbean-asm4-shaded which uses ASM4 and shades
>> to the aforementioned path.
>> But what to do with the asm3 shade?
>>
>> We now have two options:
>> Do we like to
>>
>> 1.) keep both
>>
>>
>> or do we like to
>>
>>
>> 2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and
>> only keep xbean-asm4-shaded)?
>>
>> 2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I
>> perso don't like this much as it is not so explicit for users.
>>
>> LieGrue,
>> strub
>>
>
>
>
> --
> Jean-Louis
>
--
Ivan
Re: asm4 in xbean
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Mainly a real complete support of Java 7 IMO
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/27 Jean-Louis MONTEIRO <je...@gmail.com>
> Out of curiosity, what are the objectives of such a change?
> I mean, is there any important improvments on ASM4 we cannot miss?
> Is ASM 3 end of life?
>
> Jean-Louis
>
>
>
> 2013/5/27 Mark Struberg <st...@yahoo.de>
>
>> Hi!
>>
>> A small discussion which popped up on IRC regarding asm4:
>>
>> Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same
>> packages.
>> For preventing some classpath clashes this xbean-asm-shaded package got
>> created. This was ASM3 so far.
>>
>> When moving up to ASM4 we should thus change the package we shade it in,
>> e.g. to org.apache.xbean.asm4.*
>> I think there is common agreement on this point, right?
>>
>> I've added a new module of xbean-asm4-shaded which uses ASM4 and shades
>> to the aforementioned path.
>> But what to do with the asm3 shade?
>>
>> We now have two options:
>> Do we like to
>>
>> 1.) keep both
>>
>>
>> or do we like to
>>
>>
>> 2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and
>> only keep xbean-asm4-shaded)?
>>
>> 2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I
>> perso don't like this much as it is not so explicit for users.
>>
>> LieGrue,
>> strub
>>
>
>
>
> --
> Jean-Louis
>
Re: asm4 in xbean
Posted by Mark Struberg <st...@yahoo.de>.
asm4 has java7++ support - asm3 not.
LieGrue,
strub
>________________________________
> From: Jean-Louis MONTEIRO <je...@gmail.com>
>To: dev@geronimo.apache.org; Mark Struberg <st...@yahoo.de>
>Sent: Monday, 27 May 2013, 9:40
>Subject: Re: asm4 in xbean
>
>
>
>Out of curiosity, what are the objectives of such a change?
>I mean, is there any important improvments on ASM4 we cannot miss?
>Is ASM 3 end of life?
>
>
>Jean-Louis
>
>
>
>
>
>2013/5/27 Mark Struberg <st...@yahoo.de>
>
>Hi!
>>
>>A small discussion which popped up on IRC regarding asm4:
>>
>>Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same packages.
>>For preventing some classpath clashes this xbean-asm-shaded package got created. This was ASM3 so far.
>>
>>When moving up to ASM4 we should thus change the package we shade it in, e.g. to org.apache.xbean.asm4.*
>>I think there is common agreement on this point, right?
>>
>>I've added a new module of xbean-asm4-shaded which uses ASM4 and shades to the aforementioned path.
>>But what to do with the asm3 shade?
>>
>>We now have two options:
>>Do we like to
>>
>>1.) keep both
>>
>>
>>or do we like to
>>
>>
>>2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and only keep xbean-asm4-shaded)?
>>
>>2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I perso don't like this much as it is not so explicit for users.
>>
>>LieGrue,
>>strub
>>
>
>
>
>--
>Jean-Louis
>
>
Re: asm4 in xbean
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Out of curiosity, what are the objectives of such a change?
I mean, is there any important improvments on ASM4 we cannot miss?
Is ASM 3 end of life?
Jean-Louis
2013/5/27 Mark Struberg <st...@yahoo.de>
> Hi!
>
> A small discussion which popped up on IRC regarding asm4:
>
> Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same
> packages.
> For preventing some classpath clashes this xbean-asm-shaded package got
> created. This was ASM3 so far.
>
> When moving up to ASM4 we should thus change the package we shade it in,
> e.g. to org.apache.xbean.asm4.*
> I think there is common agreement on this point, right?
>
> I've added a new module of xbean-asm4-shaded which uses ASM4 and shades to
> the aforementioned path.
> But what to do with the asm3 shade?
>
> We now have two options:
> Do we like to
>
> 1.) keep both
>
>
> or do we like to
>
>
> 2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and
> only keep xbean-asm4-shaded)?
>
> 2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I
> perso don't like this much as it is not so explicit for users.
>
> LieGrue,
> strub
>
--
Jean-Louis
Re: asm4 in xbean
Posted by Romain Manni-Bucau <rm...@gmail.com>.
+1 to remove xbean asm3 shade and upgrade xbean to support asm4 shade (in
progress)
*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*
2013/5/27 Mark Struberg <st...@yahoo.de>
> Hi!
>
> A small discussion which popped up on IRC regarding asm4:
>
> Preclusion: ASM3 and ASM4 are _not_ binary compatible but use the same
> packages.
> For preventing some classpath clashes this xbean-asm-shaded package got
> created. This was ASM3 so far.
>
> When moving up to ASM4 we should thus change the package we shade it in,
> e.g. to org.apache.xbean.asm4.*
> I think there is common agreement on this point, right?
>
> I've added a new module of xbean-asm4-shaded which uses ASM4 and shades to
> the aforementioned path.
> But what to do with the asm3 shade?
>
> We now have two options:
> Do we like to
>
> 1.) keep both
>
>
> or do we like to
>
>
> 2.) upgrade whole xbean to ASM4 and remove the old xbean-asm-shaded (and
> only keep xbean-asm4-shaded)?
>
> 2.b) keep the xbean-asm-shaded artifactId but otherwise do like 2.). I
> perso don't like this much as it is not so explicit for users.
>
> LieGrue,
> strub
>