You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2016/08/02 20:30:11 UTC
[Bug 59931] New: Misleading port after overriding client address
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Bug ID: 59931
Summary: Misleading port after overriding client address
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: Linux
Status: NEW
Severity: minor
Priority: P2
Component: mod_remoteip
Assignee: bugs@httpd.apache.org
Reporter: hwibell@gmail.com
After overriding the client IP address, the port of the useragent address is
invalid. The originating useragent port cannot be determined and should be set
to zero so that it is not misleading.
Something else to consider is that mod_log_config currently prints out the
useragent port when the %{remote}p is specified. If the useragent IP is
overrided, this will cause the logs to print the zeroed port. Should we also
update mod_log_config to handle this?
A few thoughts on what we could do:
1. Modify mod_log_config to print out the client port if the useragent port is
zero.
2. Add another option for %{}p (e.g. %{client}p) so that users can still get
the port if needed.
Any thoughts are appreciated.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Szőgyényi Gábor <sz...@freemail.hu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |szg0000@freemail.hu
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Yann Ylavic <yl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Yann Ylavic <yl...@gmail.com> ---
Backported to upcoming 2.4.34 in r1833007.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Eric Covener <co...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--- Comment #3 from Eric Covener <co...@gmail.com> ---
Thanks for the report & patch, committed in r1776458.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
--- Comment #1 from Hank Ibell <hw...@gmail.com> ---
Created attachment 34095
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34095&action=edit
Potential patch
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Tom Sommer <ma...@tomsommer.dk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mail@tomsommer.dk
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 59931] Misleading port after overriding client address
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59931
Hank Ibell <hw...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #34095|0 |1
is obsolete| |
--- Comment #2 from Hank Ibell <hw...@gmail.com> ---
Created attachment 34096
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34096&action=edit
Potential patch - 2
Moved where the port is zeroed out.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org