[GitHub] [samza] prateekm commented on issue #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb

[GitBox <gi...@apache.org>]

prateekm commented on issue #1301: Samza-2478: Add new metrics to track key and value size of records written to RocksDb
URL: https://github.com/apache/samza/pull/1301#issuecomment-595947028
 
 
   Thanks for the updated desciption @xiefan46! Minor suggestion: the "Usage instructions" section is meant for Samza users, not samza devs. I.e., we should document what users need to do to leverage this new feature. For example, for this feature you might want to clarify what new metrics can users look at?  
   
   Similarly, let's update the documentation with the new metrics as well. @rmatharu knows where that is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services