You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/30 16:33:08 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25301: [SPARK-28564][CORE] Access history application defaults to the last attempt id

dongjoon-hyun commented on a change in pull request #25301: [SPARK-28564][CORE] Access history application defaults to the last attempt id
URL: https://github.com/apache/spark/pull/25301#discussion_r308823130
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
 ##########
 @@ -632,6 +632,49 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
     }
   }
 
+  test("SPARK-28564: Access history application defaults to the last attempt id") {
 
 Review comment:
   Hi, @cxzl25 .
   Since you created a JIRA issue with `Improvement` type, we don't use JIRA ID in the test case name.
   That's because we don't add JIRA ID prefix for all new features.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org