[GitHub] clintropolis commented on a change in pull request #6883: Deprecate NoneShardSpec

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6883: Deprecate NoneShardSpec
URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r250517703
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
 ##########
 @@ -146,7 +146,7 @@ public DataSegment(
     // dataSource
     this.dimensions = prepareDimensionsOrMetrics(dimensions, DIMENSIONS_INTERNER);
     this.metrics = prepareDimensionsOrMetrics(metrics, METRICS_INTERNER);
-    this.shardSpec = (shardSpec == null) ? NoneShardSpec.instance() : shardSpec;
+    this.shardSpec = (shardSpec == null) ? new NumberedShardSpec(0, 1) : shardSpec;
 
 Review comment:
   Any reason not to have a static shared instance for `NumberedShardSpec(0, 1)` the same way we did for `NoneShardSpec`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org