You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2017/01/10 20:05:15 UTC

Fwd: logging-log4j2 git commit: LOG4J2-1243 - Allow default value in property to be a Lookup.

---------- Forwarded message ----------
From: <rg...@apache.org>
Date: Tue, Jan 10, 2017 at 7:38 AM
Subject: logging-log4j2 git commit: LOG4J2-1243 - Allow default value in
property to be a Lookup.
To: commits@logging.apache.org


Repository: logging-log4j2
Updated Branches:
  refs/heads/master ba4822b1c -> 0c2c11dbe


LOG4J2-1243 - Allow default value in property to be a Lookup.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/
commit/0c2c11db
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/0c2c11db
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/0c2c11db

Branch: refs/heads/master
Commit: 0c2c11dbe5751c1d6f2fe3e9291b09b1d9a99a53
Parents: ba4822b
Author: Ralph Goers <rg...@nextiva.com>
Authored: Tue Jan 10 08:38:02 2017 -0700
Committer: Ralph Goers <rg...@nextiva.com>
Committed: Tue Jan 10 08:38:02 2017 -0700

----------------------------------------------------------------------
 .../core/config/plugins/processor/PluginProcessor.java  |  5 +++--
 .../apache/logging/log4j/core/lookup/Interpolator.java  |  3 ++-
 .../logging/log4j/core/lookup/StrSubstitutor.java       | 10 ++++++++--
 .../logging/log4j/core/lookup/InterpolatorTest.java     |  5 +++++
 .../logging/log4j/core/lookup/StrSubstitutorTest.java   | 12 ++++++++++++
 src/changes/changes.xml                                 |  3 +++
 6 files changed, 33 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/
0c2c11db/log4j-core/src/main/java/org/apache/logging/log4j/
core/config/plugins/processor/PluginProcessor.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/
config/plugins/processor/PluginProcessor.java b/log4j-core/src/main/java/
org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java
index 13a83a6..c7db024 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/
config/plugins/processor/PluginProcessor.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/
config/plugins/processor/PluginProcessor.java
@@ -22,6 +22,7 @@ import java.io.OutputStream;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Set;
@@ -127,7 +128,7 @@ public class PluginProcessor extends AbstractProcessor {
         public PluginEntry visitType(final TypeElement e, final Plugin
plugin) {
             Objects.requireNonNull(plugin, "Plugin annotation is null.");
             final PluginEntry entry = new PluginEntry();
-            entry.setKey(plugin.name().toLowerCase());
+            entry.setKey(plugin.name().toLowerCase(Locale.US));

How about adding a lower-case version of:

org.apache.logging.log4j.util.Strings.toRootUpperCase(String)

?

Gary