[jira] [Commented] (SOLR-13622) Add FileStream Streaming Expression

["Jason Gerlowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929653#comment-16929653 ] 

Jason Gerlowski commented on SOLR-13622:
----------------------------------------

Yes, it looks like there's a handle leak there.  File handles get closed when "cat"-ing is truncated by the maxLines parameter.  And I believe the behavior is correct for 0-byte files.  It's the "vanilla" case that was missing handle-cleanup on the last handle in the group.

I've got a fix for this, but I'll sleep on it and look for other issues.  Hope to get a patch up and/or commit tomorrow.

Thanks for pointing out the issue, and for the analysis and guesses Hoss.  Def made tracking this down easier.

> Add FileStream Streaming Expression
> -----------------------------------
>
>                 Key: SOLR-13622
>                 URL: https://issues.apache.org/jira/browse/SOLR-13622
>             Project: Solr
>          Issue Type: New Feature
>          Components: streaming expressions
>            Reporter: Joel Bernstein
>            Assignee: Jason Gerlowski
>            Priority: Major
>             Fix For: 8.3
>
>         Attachments: SOLR-13622.patch, SOLR-13622.patch
>
>
> The FileStream will read files from a local filesystem and Stream back each line of the file as a tuple.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org