You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by technmsg <gi...@git.apache.org> on 2015/10/19 20:18:43 UTC
[GitHub] nifi pull request: NIFI-1046 clean up shell scripts
GitHub user technmsg opened a pull request:
https://github.com/apache/nifi/pull/106
NIFI-1046 clean up shell scripts
Didn't squash specifically to ease review what was changed in each pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/technmsg/nifi patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 5dcebf3aae64e6d564b3e76372b942045b1da9f7
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T17:42:28Z
shell clean up: remove backticks from nifi.sh
commit 909faa59d2002b16a734a8dcad32e04a99cd9b11
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T18:02:39Z
shell clean up: quoting prevents globbing & word splitting
Ignoring the unquoted array expansions on L188/190; suspect they ought to be quoted per [SC2068](https://github.com/koalaman/shellcheck/wiki/SC2068), but need to confirm desired arguments.
commit 7f3b38324398336f47e2179796014f7e6c7c52dd
Author: Alex Moundalexis <al...@cloudera.com>
Date: 2015-10-19T18:14:32Z
shell clean up: +variable braces for consistency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1046 clean up shell scripts
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/106#issuecomment-149375547
5dcebf3 looks great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1046 clean up shell scripts
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/106#issuecomment-149380661
909faa5 fixes several bugs in the sh script, notably when the directory being run out of has a space in it.
Confirmed code looks good and it works as expected in linux. working on cygwin now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1046 clean up shell scripts
Posted by trkurc <gi...@git.apache.org>.
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/106#issuecomment-149375130
7f3b383 looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1046 clean up shell scripts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---