You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by patricklucas <gi...@git.apache.org> on 2017/02/06 00:22:01 UTC
[GitHub] flink pull request #3268: [FLINK-5153] Support YARN application tags
GitHub user patricklucas opened a pull request:
https://github.com/apache/flink/pull/3268
[FLINK-5153] Support YARN application tags
Adds a new config option `yarn.tags`, a comma-separated list of strings
passed to YARN as application tags.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricklucas/flink FLINK-5153_support_yarn_application_tags
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3268
----
commit b4599e3aa3c10f86354336c258870703e91e1415
Author: Patrick Lucas <me...@patricklucas.com>
Date: 2017-02-04T00:17:55Z
[FLINK-5153] Support YARN application tags
Adds a new config option `yarn.tags`, a comma-separated list of strings
passed to YARN as application tags.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3268: [FLINK-5153] Support YARN application tags
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3268
@patricklucas Can you manually close the PR? We usually do this automatically, but I forgot to add the right string the commit message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3268: [FLINK-5153] Support YARN application tags
Posted by patricklucas <gi...@git.apache.org>.
Github user patricklucas closed the pull request at:
https://github.com/apache/flink/pull/3268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3268: [FLINK-5153] Support YARN application tags
Posted by patricklucas <gi...@git.apache.org>.
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3268
I manually tested the behavior of this new feature as well as the other YARN application options touched by this change with various Hadoop versions (2.3/2.4/2.6) on a YARN cluster.
The Travis builds have tended to fail by timing out after 50 min, but everything tests fine locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3268: [FLINK-5153] Support YARN application tags
Posted by patricklucas <gi...@git.apache.org>.
Github user patricklucas commented on the issue:
https://github.com/apache/flink/pull/3268
I added the test (which of course also required reflection) to an existing test case. I figured that was the lesser of the two evils of requiring another test application be deployed and hiding a test within a (somewhat) unrelated one.
It was a bit tricky to actually run the tests, but I verified the correct behavior with both hadoop < 2.4 and >= 2.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3268: [FLINK-5153] Support YARN application tags
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3268
I'll merge the change now.
I've also tested it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3268: [FLINK-5153] Support YARN application tags
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/3268
Hi Patrick,
the change looks good in general (you updated the documentation as well :) ).
One thing I'm missing a bit from the change is a test case.
We have an entire package (which is, admittedly pretty ugly) for YARN tests.
Maybe you can just pass your new config option to one of the existing tests and then check if the tag has been set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---