[GitHub] [spark] zhengruifeng commented on a change in pull request #35678: [SPARK-38346][MLLIB] Add cache in MLlib BinaryClassificationMetrics

[GitBox <gi...@apache.org>]

zhengruifeng commented on a change in pull request #35678:
URL: https://github.com/apache/spark/pull/35678#discussion_r817277889



##########
File path: mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
##########
@@ -113,7 +113,7 @@ class BinaryClassificationMetrics @Since("3.0.0") (
       } else {
         iter
       }
-    }
+    }.cache()

Review comment:
       you can cache the returned rdd on your own purpose. 
   We should not cache it here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org