[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #418: Incorporate IP configuration files into netinit.

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #418:
URL: https://github.com/apache/incubator-nuttx-apps/pull/418#discussion_r500280302



##########
File path: netutils/netinit/netinit.c
##########
@@ -344,66 +340,239 @@ static void netinit_set_macaddr(void)
 #endif
 
 /****************************************************************************
- * Name: netinit_set_ipaddrs
+ * Name: netinit_set_ipv4addrs
  *
  * Description:
- *   Setup IP addresses.
- *
- *   For 6LoWPAN, the IP address derives from the MAC address.  Setting it
- *   to any user provided value is asking for trouble.
+ *   Setup IPv4 addresses.
  *
  ****************************************************************************/
 
 #if defined(NETINIT_HAVE_NETDEV) && !defined(CONFIG_NET_6LOWPAN) && ! \
-    defined(CONFIG_NET_IEEE802154)
-static void netinit_set_ipaddrs(void)
+    defined(CONFIG_NET_IEEE802154) && defined(CONFIG_NET_IPv4)
+static inline void netinit_set_ipv4addrs(void)
 {
-#ifdef CONFIG_NET_IPv4
   struct in_addr addr;
+#ifdef CONFIG_FSUTILS_IPCFG
+  struct ipv4cfg_s ipv4cfg;
+  int ret;
+#endif
 
-  /* Set up our host address */
+#ifdef CONFIG_FSUTILS_IPCFG

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org