[GitHub] [arrow-datafusion] alamb commented on a change in pull request #2023: Add `write_json`, `read_json`, `register_json`, and `JsonFormat` to `CREATE EXTERNAL TABLE` functionality

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #2023:
URL: https://github.com/apache/arrow-datafusion/pull/2023#discussion_r832677950



##########
File path: datafusion/tests/sql/avro.rs
##########
@@ -133,7 +133,7 @@ async fn avro_single_nan_schema() {
 }
 
 #[tokio::test]
-async fn avro_explain() {
+async fn json_explain() {

Review comment:
       this should probably still be `avro_explain` I think

##########
File path: datafusion/tests/sql/avro.rs
##########
@@ -133,7 +133,7 @@ async fn avro_single_nan_schema() {
 }
 
 #[tokio::test]
-async fn avro_explain() {
+async fn json_explain() {

Review comment:
       ```suggestion
   async fn avro_explain() {
   ```

##########
File path: datafusion/tests/sql/json.rs
##########
@@ -17,135 +17,76 @@
 
 use super::*;
 
-async fn register_alltypes_avro(ctx: &mut SessionContext) {
-    let testdata = datafusion::test_util::arrow_test_data();
-    ctx.register_avro(
-        "alltypes_plain",
-        &format!("{}/avro/alltypes_plain.avro", testdata),
-        NdJsonReadOptions::default(),
-    )
-    .await
-    .unwrap();
-}
+const TEST_DATA_BASE: &str = "tests/jsons";
 
 #[tokio::test]
-async fn avro_query() {
+async fn json_query() {

Review comment:
       👍 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org