You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ka...@apache.org on 2021/01/07 20:00:47 UTC

[airflow] branch master updated: Remove thrift as a core dependency (#13471)

This is an automated email from the ASF dual-hosted git repository.

kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/master by this push:
     new b5d921b  Remove thrift as a core dependency (#13471)
b5d921b is described below

commit b5d921bd921e02e6ff2a4f3b4af348c6a53120b2
Author: Kaxil Naik <ka...@gmail.com>
AuthorDate: Thu Jan 7 20:00:35 2021 +0000

    Remove thrift as a core dependency (#13471)
    
    `thrift` is a dependency for Apache Hive and it is not required by Core Airflow:
    
    ```
    airflow/providers/apache/hive/hooks/hive.py:489:        # This is for pickling to work despite the thrift hive client not
    airflow/providers/apache/hive/hooks/hive.py:500:        """Returns a Hive thrift client."""
    airflow/providers/apache/hive/hooks/hive.py:502:        from thrift.protocol import TBinaryProtocol
    airflow/providers/apache/hive/hooks/hive.py:503:        from thrift.transport import TSocket, TTransport
    airflow/providers/apache/hive/hooks/hive.py:531:            from thrift_sasl import TSaslClientTransport
    airflow/providers/apache/hive/sensors/hive_partition.py:41:    :param metastore_conn_id: reference to the metastore thrift service
    airflow/providers/apache/hive/sensors/metastore_partition.py:28:    queries generated by the Metastore thrift service when hitting
    airflow/providers/apache/hive/sensors/named_hive_partition.py:36:    :param metastore_conn_id: reference to the metastore thrift service
    ```
---
 setup.cfg | 1 -
 setup.py  | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup.cfg b/setup.cfg
index 9cb33f9..3d1beab 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -133,7 +133,6 @@ install_requires =
     tabulate>=0.7.5, <0.9
     tenacity~=6.2.0
     termcolor>=1.1.0
-    thrift>=0.9.2
     typing-extensions>=3.7.4;python_version<"3.8"
     unicodecsv>=0.14.1
     urllib3<1.26  # Required to keep boto3 happy
diff --git a/setup.py b/setup.py
index bf2e3c9..ef92e34 100644
--- a/setup.py
+++ b/setup.py
@@ -292,6 +292,7 @@ hdfs = [
 hive = [
     'hmsclient>=0.1.0',
     'pyhive[hive]>=0.6.0',
+    'thrift>=0.9.2',
 ]
 jdbc = [
     'jaydebeapi>=1.1.1',