You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/21 01:28:48 UTC

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #368: [YUNIKORN-979] Add e2e test coverage for the admission controller

wilfred-s commented on pull request #368:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/368#issuecomment-1046385616


   @lowc1012 can you have a look at the two lint issues?
   The kClient is a strange one to get. Not something you would expect. It is linked to not using the Hungarian notation. The go lint code specifically picks up on the `k` which stands for kind in that case. Rename the variable to kubeClient or just to client can be used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org