You are viewing a plain text version of this content. The canonical link for it is here.
Posted to npanday-dev@incubator.apache.org by Brett Porter <br...@apache.org> on 2011/01/07 06:55:51 UTC

Re: svn commit: r1049437 - in /incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact: ArtifactRepository.cs PathUtil.cs

On 15/12/2010, at 4:54 PM, apadilla@apache.org wrote:

> Author: apadilla
> Date: Wed Dec 15 05:54:57 2010
> New Revision: 1049437
> 
> URL: http://svn.apache.org/viewvc?rev=1049437&view=rev
> Log:
> [NPANDAY-360] 
> - fixed the incorrect display of artifacts in the Local tab when adding a Maven artifact
> * passed the repository configured in settings.xml so that NPanday will look into that as the local repository. 
> * revised parsing of tokens passed to display the correct information of the artifact
> 
> Modified:
>    incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
>    incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/PathUtil.cs
> 
> Modified: incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
> URL: http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs?rev=1049437&r1=1049436&r2=1049437&view=diff
> ==============================================================================
> --- incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs (original)
> +++ incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs Wed Dec 15 05:54:57 2010
> @@ -110,16 +110,17 @@ namespace NPanday.Artifact
>             List<Artifact> artifacts = new List<Artifact>();
>             try
>             {
> -                DirectoryInfo uac = new DirectoryInfo(localRepository.FullName);
> -                int directoryStartPosition = uac.FullName.Length;
> +                String repo = localRepository.FullName + "\\repository";

is appending \\repository intentional? That seems like it would change behaviour.

- Brett

--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter





Re: svn commit: r1049437 - in /incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact: ArtifactRepository.cs PathUtil.cs

Posted by Adelita Padilla <ap...@maestrodev.com>.
Hi Brett,

Revised the url passed in r1065518.


Thanks,

--

liit

----- "Brett Porter" <br...@apache.org> wrote:

> On 15/12/2010, at 4:54 PM, apadilla@apache.org wrote:
> 
> > Author: apadilla
> > Date: Wed Dec 15 05:54:57 2010
> > New Revision: 1049437
> > 
> > URL: http://svn.apache.org/viewvc?rev=1049437&view=rev
> > Log:
> > [NPANDAY-360] 
> > - fixed the incorrect display of artifacts in the Local tab when
> adding a Maven artifact
> > * passed the repository configured in settings.xml so that NPanday
> will look into that as the local repository. 
> > * revised parsing of tokens passed to display the correct
> information of the artifact
> > 
> > Modified:
> >   
> incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
> >   
> incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/PathUtil.cs
> > 
> > Modified:
> incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
> > URL:
> http://svn.apache.org/viewvc/incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs?rev=1049437&r1=1049436&r2=1049437&view=diff
> >
> ==============================================================================
> > ---
> incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
> (original)
> > +++
> incubator/npanday/trunk/dotnet/assemblies/NPanday.Artifact/src/main/csharp/NPanday/Artifact/ArtifactRepository.cs
> Wed Dec 15 05:54:57 2010
> > @@ -110,16 +110,17 @@ namespace NPanday.Artifact
> >             List<Artifact> artifacts = new List<Artifact>();
> >             try
> >             {
> > -                DirectoryInfo uac = new
> DirectoryInfo(localRepository.FullName);
> > -                int directoryStartPosition = uac.FullName.Length;
> > +                String repo = localRepository.FullName +
> "\\repository";
> 
> is appending \\repository intentional? That seems like it would change
> behaviour.
> 
> - Brett
> 
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter