[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5958: updating deprecated links

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #5958:
URL: https://github.com/apache/trafficcontrol/pull/5958#discussion_r655583323



##########
File path: .github/workflows/tr.unit.tests.yaml
##########
@@ -24,13 +24,13 @@ env:
 on:
   push:
     paths:
-      - .github/actions/tr-tests/**
+      - .github/actions/tr-unit-tests/**

Review comment:
       I'm hoping to get the *TR Tests* GitHub Action to run the TR integration tests soon, so IMO we should leave it at *tr-tests* for now.

##########
File path: .github/workflows/tr.unit.tests.yaml
##########
@@ -56,8 +56,8 @@ jobs:
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-maven-
-      - name: Run unit tests
-        uses: ./.github/actions/tr-tests
+      - name: Run Traffic Router unit tests

Review comment:
       Since this GitHub Actions step rename is not related to updating Grafana dashboard links, would you mind opening a separate PR for this?

##########
File path: .github/workflows/tr.unit.tests.yaml
##########
@@ -56,8 +56,8 @@ jobs:
           key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
           restore-keys: |
             ${{ runner.os }}-maven-
-      - name: Run unit tests
-        uses: ./.github/actions/tr-tests
+      - name: Run Traffic Router unit tests
+        uses: ./.github/actions/tr-unit-tests

Review comment:
       I'm hoping to get the *TR Tests* GitHub Action to run the TR integration tests soon, so IMO we should leave it at *tr-tests* for now.

##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -208,7 +208,7 @@ tp_default_properties_template:
         _comment: Do you want to show a charts button for each server? If so, where
           can the charts be found? xml id will be appended to the provided url.
         show: false
-        baseUrl: "{{ tp_ts_base_url }}/dashboard/script/traffic_ops_server.js?which="
+        baseUrl: "{{ tp_ts_base_url }}/dashboard/db/server-stats?var-SERVER="

Review comment:
       `traffic_ops_server.js` is in our repo at [/traffic_stats/grafana/traffic_ops_server.js](https://github.com/apache/trafficcontrol/blob/048a1ea016/traffic_stats/grafana/traffic_ops_server.js). If the `cdn-overview` dashboard is not publicly available, I would be hesitant to reference it here.

##########
File path: infrastructure/ansible/roles/traffic_portal/defaults/main.yml
##########
@@ -196,7 +196,7 @@ tp_default_properties_template:
         customLink:
           _comment: Do you want to show a custom link to your own ds dashboards?
           show: false
-          baseUrl: "{{ tp_ts_base_url }}/dashboard/script/traffic_ops_deliveryservice.js?which="
+          baseUrl: "{{ tp_ts_base_url }}/dashboard/db/cdn-overview?var-svc="

Review comment:
       `traffic_ops_deliveryservice.js` is in our repo at [/traffic_stats/grafana/traffic_ops_deliveryservice.js](https://github.com/apache/trafficcontrol/blob/048a1ea016/traffic_stats/grafana/traffic_ops_deliveryservice.js). If the `cdn-overview` dashboard is not publicly available, I would be hesitant to reference it here.

##########
File path: .github/workflows/tr.unit.tests.yaml
##########
@@ -24,13 +24,13 @@ env:
 on:
   push:
     paths:
-      - .github/actions/tr-tests/**
+      - .github/actions/tr-unit-tests/**
       - .github/workflows/tr.unit.tests.yaml
       - traffic_router/**
   create:
   pull_request:
     paths:
-      - .github/actions/tr-tests/**
+      - .github/actions/tr-unit-tests/**

Review comment:
       I'm hoping to get the *TR Tests* GitHub Action to run the TR integration tests soon, so IMO we should leave it at *tr-tests* for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org