You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Adrian Cumiskey (Created) (JIRA)" <ji...@apache.org> on 2011/10/28 23:07:32 UTC
[jira] [Created] (OGNL-33) [PATCH] Improvements to
JJTOgnlParserState
[PATCH] Improvements to JJTOgnlParserState
------------------------------------------
Key: OGNL-33
URL: https://issues.apache.org/jira/browse/OGNL-33
Project: OGNL
Issue Type: Improvement
Reporter: Adrian Cumiskey
Priority: Minor
JJTOgnlParserState was looking a little old school.
* Introduced generics on the "nodes" and "marks" List.
* Replaced 1-3 character acronyms with meaningful, camel case variable names.
* Removed unnecessary use of (un)boxing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-33) [PATCH] Improvements to
JJTOgnlParserState
Posted by "Adrian Cumiskey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139259#comment-13139259 ]
Adrian Cumiskey commented on OGNL-33:
-------------------------------------
Hi Maurizio,
I also noticed that this class was previously created by javacc. I looked through the codebaee and could not find the source of the generation. My guess is that it is no longer generated otherwise the class would most likely have resided in the generated/src tree. Perhaps we could now remove the generation comments? Thanks again for your timely processing of my patches.
Cheers, Adrian.
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
> Key: OGNL-33
> URL: https://issues.apache.org/jira/browse/OGNL-33
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OGNL-33) [PATCH] Improvements to
JJTOgnlParserState
Posted by "Adrian Cumiskey (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Cumiskey updated OGNL-33:
--------------------------------
Attachment: patch-OGNL33.txt
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
> Key: OGNL-33
> URL: https://issues.apache.org/jira/browse/OGNL-33
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OGNL-33) [PATCH] Improvements to
JJTOgnlParserState
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139130#comment-13139130 ]
Hudson commented on OGNL-33:
----------------------------
Integrated in ognl #170 (See [https://builds.apache.org/job/ognl/170/])
OGNL-33 - Improvements to JJTOgnlParserState (contributed by Adrian Cumiskey)
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1190760
Files :
* /commons/proper/ognl/trunk/src/changes/changes.xml
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/JJTOgnlParserState.java
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
> Key: OGNL-33
> URL: https://issues.apache.org/jira/browse/OGNL-33
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OGNL-33) [PATCH] Improvements to
JJTOgnlParserState
Posted by "Maurizio Cucchiara (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maurizio Cucchiara resolved OGNL-33.
------------------------------------
Resolution: Fixed
Assignee: Maurizio Cucchiara
Adrian,
this was a class originally created by javacc, hence I don't know if in the future someone will replace your change with a new generated class.
ATM I applied the patch, b/c i think is a good one.
Thank you again.
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
> Key: OGNL-33
> URL: https://issues.apache.org/jira/browse/OGNL-33
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Assignee: Maurizio Cucchiara
> Priority: Minor
> Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira