You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Riza Suminto (Jira)" <ji...@apache.org> on 2023/11/02 00:11:00 UTC

[jira] [Resolved] (IMPALA-12524) Duplicate TestTextScanRangeLengths in test_scanners.py

     [ https://issues.apache.org/jira/browse/IMPALA-12524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Riza Suminto resolved IMPALA-12524.
-----------------------------------
    Fix Version/s: Impala 4.4.0
       Resolution: Fixed

> Duplicate TestTextScanRangeLengths in test_scanners.py
> ------------------------------------------------------
>
>                 Key: IMPALA-12524
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12524
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Infrastructure
>    Affects Versions: Impala 4.3.0
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Minor
>             Fix For: Impala 4.4.0
>
>
> There is a duplicate TestTextScanRangeLengths class in test_scanners.py
> [https://github.com/apache/impala/blob/248060528abd7fb5425f519ee1608598ed2d3ac3/tests/query_test/test_scanners.py#L1377]
> [https://github.com/apache/impala/blob/248060528abd7fb5425f519ee1608598ed2d3ac3/tests/query_test/test_scanners.py#L1494] 
> The name should be unique for both test class within same file to run properly.
> Simple grep found another duplicates at TestObservability and TestCompactCatalogUpdates. These other duplicates does not cause issue because they are defined in separate test files: test_local_catalog.py, test_observability.py, and test_compact_catalog_updates.py. But ideally they should be distinguishable.
> {code:java}
> $ git grep "^class Test" tests/ | cut -d":" -f2 | sort |uniq -c | sort | tail -n 5
>       1 class TestZippingUnnestFromView(ImpalaTestSuite)
>       1 class TestZippingUnnest(ImpalaTestSuite)
>       2 class TestCompactCatalogUpdates(CustomClusterTestSuite)
>       2 class TestObservability(CustomClusterTestSuite)
>       2 class TestTextScanRangeLengths(ImpalaTestSuite) {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org