You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2024/03/23 16:35:36 UTC
[PR] Remove experimental maven download feature. [netbeans]
mbien opened a new pull request, #7182:
URL: https://github.com/apache/netbeans/pull/7182
got replaced by mvnw https://github.com/apache/netbeans/pull/3198 / https://github.com/apache/netbeans/pull/7076#discussion_r1497899551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536889255
##########
java/maven/src/org/netbeans/modules/maven/options/MavenSettings.java:
##########
Review Comment:
Would it make sense to modify the getter to return the default value and make the setter no-ops?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#issuecomment-2016932622
> I hope that maven does not go down the "lets create a product that breaks on every minor JDK change" (aka gradle) route, but that is a different discussion.
I am following the maven dev list a bit and I don't think we have to worry about that. Maven 4 won't have a different approach to compatibility than Maven 3 has. Maven 3 will also stick around for a while in maintenance mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536870485
##########
java/maven/nbproject/project.properties:
##########
@@ -34,7 +34,7 @@ test.config.stableBTD.excludes=\
jnlp.indirect.files=maven-nblib/netbeans-eventspy.jar,maven-nblib/netbeans-cos.jar
-# requires nb.javac for compiling of tests
+# TODO remove after JDK 17 bump (code uses CompilationUnitTree#getModule)
requires.nb.javac=true
Review Comment:
since gradle is going to be 17+, maybe we should do this here too. I saw some sig validation issues in the log when I tried this so I didn't really bother. However that was before https://github.com/apache/netbeans/pull/7117, maybe I should give it another try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536891535
##########
java/maven/src/org/netbeans/modules/maven/options/MavenSettings.java:
##########
Review Comment:
maybe I was overthinking it but my thought was that the safest degradation would be to do nothing and deprecate it?
realistically nothing should read this anymore within NB, so it should not really matter if something downstream is still writing to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #7182:
URL: https://github.com/apache/netbeans/pull/7182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536892329
##########
java/maven/src/org/netbeans/modules/maven/options/MavenSettings.java:
##########
Review Comment:
but on the other hand - lets return the default values, this allows us to remove a few props more and since nothing is actually using it within NB it should cause no problems indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove experimental maven download feature. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7182:
URL: https://github.com/apache/netbeans/pull/7182#discussion_r1536870485
##########
java/maven/nbproject/project.properties:
##########
@@ -34,7 +34,7 @@ test.config.stableBTD.excludes=\
jnlp.indirect.files=maven-nblib/netbeans-eventspy.jar,maven-nblib/netbeans-cos.jar
-# requires nb.javac for compiling of tests
+# TODO remove after JDK 17 bump (code uses CompilationUnitTree#getModule)
requires.nb.javac=true
Review Comment:
since gradle support is going to be 17+, maybe we should do this here too. I saw some sig validation issues in the log when I tried this so I didn't really bother. However that was before https://github.com/apache/netbeans/pull/7117, maybe I should give it another try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists