[GitHub] [arrow] pitrou commented on a change in pull request #11838: ARROW-14779: [C++] Add other common round mode names to RoundMode docs

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #11838:
URL: https://github.com/apache/arrow/pull/11838#discussion_r761236865



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -57,19 +57,19 @@ class ARROW_EXPORT ElementWiseAggregateOptions : public FunctionOptions {
 enum class RoundMode : int8_t {
   /// Round to nearest integer less than or equal in magnitude (aka "floor")
   DOWN,
-  /// Round to nearest integer greater than or equal in magnitude (aka "ceil")
+  /// Round to nearest integer greater than or equal in magnitude (aka "ceiling")

Review comment:
       Hmm, "trunc" and "ceil" are common API names for this, for example [in C](https://pubs.opengroup.org/onlinepubs/9699919799/functions/ceil.html), [Python](https://docs.python.org/3/library/math.html#math.ceil) or [Rust](https://doc.rust-lang.org/std/primitive.f64.html#method.ceil), so perhaps keep those names here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org