You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/24 08:38:17 UTC
[GitHub] [apisix] liangliang4ward opened a new issue #6709: feat: file-log-plugin should combine with log-rotate
liangliang4ward opened a new issue #6709:
URL: https://github.com/apache/apisix/issues/6709
### Description
I found that file-log-plugin just write one file. I think we can combine with log-rotate plugin to split file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079920955
This is not easy to combine these two plugins. But we can make a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079717169
good idea, we should make the file logger itself support log file rotation.. cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
liangliang4ward commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1081295284
> > This is not easy to combine these two plugins. But we can make a try.
>
> Maybe we can make file-logger support log file rotation (without modifying the log-rotate plugin, or extracting some common functions)?
yes, I think it can be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1077659748
They are not really related, can you give more details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
liangliang4ward commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079671686
I mean ,the file-log-plugin write only one file. I think the file will be very large. we should split them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #6709:
URL: https://github.com/apache/apisix/issues/6709#issuecomment-1080066439
> This is not easy to combine these two plugins. But we can make a try.
Maybe we can make file-logger support log file rotation (without modifying the log-rotate plugin, or extracting some common functions)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org